Source/core/html/HTMLElement.cpp - Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLElement.cpp

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/BaseButtonInputType.h ('K') | « Source/core/html/HTMLButtonElement.cpp ('k') | Source/core/html/HTMLFieldSetElement.h » ('j') | Source/core/html/HTMLFormControlElementWithState.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLElement.cpp

diff --git a/Source/core/html/HTMLElement.cpp b/Source/core/html/HTMLElement.cpp

index 04ce873d29c837959c01e1b77160cb554c321d39..598b3df66ce7edeaa0419f72e56c303bc4e59e27 100644

--- a/Source/core/html/HTMLElement.cpp

+++ b/Source/core/html/HTMLElement.cpp

@@ -847,11 +847,11 @@ TextDirection HTMLElement::directionalityIfhasDirAutoAttribute(bool& isAuto) con

TextDirection HTMLElement::directionality(Node** strongDirectionalityTextNode) const

{

if (isHTMLTextFormControlElement(this)) {

- HTMLTextFormControlElement* textElement = toHTMLTextFormControlElement(const_cast<HTMLElement*>(this));

+ Handle<HTMLTextFormControlElement> textElement = toHTMLTextFormControlElement(const_cast<HTMLElement*>(this));

bool hasStrongDirectionality;

Unicode::Direction textDirection = textElement->value().defaultWritingDirection(&hasStrongDirectionality);

if (strongDirectionalityTextNode)

- *strongDirectionalityTextNode = hasStrongDirectionality ? textElement : 0;

+ *strongDirectionalityTextNode = hasStrongDirectionality ? textElement.raw() : 0;

return (textDirection == Unicode::LeftToRight) ? LTR : RTL;

}