Source/core/html/BaseButtonInputType.cpp - Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/BaseButtonInputType.cpp

Issue 19509003: [oilpan] Completely move HTMLFormControlElement's hierarchy to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/BaseButtonInputType.h ('K') | « Source/core/html/BaseButtonInputType.h ('k') | Source/core/html/BaseCheckableInputType.h » ('j') | Source/core/html/HTMLFormControlElementWithState.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/BaseButtonInputType.cpp

diff --git a/Source/core/html/BaseButtonInputType.cpp b/Source/core/html/BaseButtonInputType.cpp

index 75f97ec243ae7640b138cf75b3a8e3a6c63e590c..e3b6b296e7c6050d49d4c630e30853518b54bac7 100644

--- a/Source/core/html/BaseButtonInputType.cpp

+++ b/Source/core/html/BaseButtonInputType.cpp

@@ -41,6 +41,11 @@ namespace WebCore {

using namespace HTMLNames;

+BaseButtonInputType::BaseButtonInputType(const Handle<HTMLInputElement>& element)

+ : BaseClickableWithKeyInputType(element)

bool BaseButtonInputType::shouldSaveAndRestoreFormControlState() const

{

return false;

@@ -54,7 +59,7 @@ bool BaseButtonInputType::appendFormData(FormDataList&, bool) const

RenderObject* BaseButtonInputType::createRenderer(RenderArena* arena, RenderStyle*) const

{

- return new (arena) RenderButton(element());

+ return new (arena) RenderButton(Handle<HTMLInputElement>(element()).raw());

}

bool BaseButtonInputType::storesValueSeparateFromAttribute()