Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1950863002: [Views] Center bubble title text vertically when title icon is tall. (Closed)

Created:
4 years, 7 months ago by Evan Stade
Modified:
4 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, extensions-reviews_chromium.org, msw+watch_chromium.org, tfarina, groby+bubble_chromium.org, hcarmona+bubble_chromium.org, chromium-apps-reviews_chromium.org, rouslan+bubble_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Views] Center bubble title text vertically when title icon is tall. BUG=608274 Committed: https://crrev.com/7348b202e0b2c02f7fab1fc03b6f9e7b84d83c1c Cr-Commit-Position: refs/heads/master@{#391592}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 2 chunks +0 lines, -4 lines 1 comment Download
M ui/views/bubble/bubble_frame_view.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Evan Stade
https://codereview.chromium.org/1950863002/diff/1/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc File chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc (left): https://codereview.chromium.org/1950863002/diff/1/chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc#oldcode241 chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc:241: // Move explanatory text closer to the title. this ...
4 years, 7 months ago (2016-05-04 01:35:29 UTC) #2
msw
I wonder if the vertical centering will look weird anywhere, but it actually looks better ...
4 years, 7 months ago (2016-05-04 16:43:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950863002/1
4 years, 7 months ago (2016-05-04 17:25:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 19:09:19 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 19:10:48 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7348b202e0b2c02f7fab1fc03b6f9e7b84d83c1c
Cr-Commit-Position: refs/heads/master@{#391592}

Powered by Google App Engine
This is Rietveld 408576698