[Views] Center bubble title text vertically when title icon is tall.

[Views] Center bubble title text vertically when title icon is tall.

BUG=608274
Committed: https://crrev.com/7348b202e0b2c02f7fab1fc03b6f9e7b84d83c1c
Cr-Commit-Position: refs/heads/master@{#391592}

[Evan Stade, 2016-05-04 01:35:28]

estade@chromium.org changed reviewers:
+ msw@chromium.org

[Evan Stade, 2016-05-04 01:35:29]

https://codereview.chromium.org/1950863002/diff/1/chrome/browser/ui/views/ext...
File chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc
(left):

https://codereview.chromium.org/1950863002/diff/1/chrome/browser/ui/views/ext...
chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc:241: //
Move explanatory text closer to the title.
this was previously necessary because the title text was aligned to the top of
the icon, which left a bit of space beneath the text and it looked more natural
not to have a top inset on the content.

It broke the footnote view because that view reuses the content margins
(actually, I'm to blame for this).

This patch is probably a better way to fix this. Here's the before/after*:
https://screenshot.googleplex.com/06FAiVTtoGS.png

*I had to increase the width of the bubble to make the title fit on one line,
since "Chromium" is longer than "Chrome". Here's what it actually ends up
looking like without the extra horizontal space (title therefore wrapping): 
https://screenshot.googleplex.com/5rBVxuX7qOr.png

[Evan Stade, 2016-05-04 01:36:00]

Description was changed from

==========
Center bubble title text when title icon is large.

BUG=608274
==========

to

==========
[Views] Center bubble title text vertically when title icon is tall.

BUG=608274
==========

[msw, 2016-05-04 16:43:10]

I wonder if the vertical centering will look weird anywhere, but it actually
looks better than top-alignment in your before/after shot. lgtm

[Evan Stade, 2016-05-04 17:24:50]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-05-04 17:25:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950863002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950863002/1

[commit-bot: I haz the power, 2016-05-04 19:09:18]

Description was changed from

==========
[Views] Center bubble title text vertically when title icon is tall.

BUG=608274
==========

to

==========
[Views] Center bubble title text vertically when title icon is tall.

BUG=608274
==========

[commit-bot: I haz the power, 2016-05-04 19:09:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-04 19:10:47]

Description was changed from

==========
[Views] Center bubble title text vertically when title icon is tall.

BUG=608274
==========

to

==========
[Views] Center bubble title text vertically when title icon is tall.

BUG=608274

Committed: https://crrev.com/7348b202e0b2c02f7fab1fc03b6f9e7b84d83c1c
Cr-Commit-Position: refs/heads/master@{#391592}
==========

[commit-bot: I haz the power, 2016-05-04 19:10:48]

Patchset 1 (id:??) landed as
https://crrev.com/7348b202e0b2c02f7fab1fc03b6f9e7b84d83c1c
Cr-Commit-Position: refs/heads/master@{#391592}