[Views] Center bubble title text vertically when title icon is tall.

chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/user_metrics_action.h"
@@ skipping 200 matching lines @@
 
 int ExtensionInstalledBubbleView::GetDialogButtons() const {
   return ui::DIALOG_BUTTON_NONE;
 }
 
 bool ExtensionInstalledBubbleView::ShouldShowCloseButton() const {
   return true;
 }
 
 void ExtensionInstalledBubbleView::Init() {
-  gfx::Insets insets = margins();
   UpdateAnchorView();
 
   // The Extension Installed bubble takes on various forms, depending on the
   // type of extension installed. In general, though, they are all similar:
   //
   // -------------------------
   // | Icon | Title      (x) |
   // |        Info           |
   // |        Extra info     |
   // -------------------------
   //
   // Icon and Title are always shown (as well as the close button).
   // Info is shown for browser actions, page actions and Omnibox keyword
   // extensions and might list keyboard shorcut for the former two types.
   // Extra info is...
   // ... for other types, either a description of how to manage the extension
   //     or a link to configure the keybinding shortcut (if one exists).
   // Extra info can include a promo for signing into sync.
 
-  // Move explanatory text closer to the title.

[Evan Stade, 2016/05/04 01:35:29]

this was previously necessary because the title text was aligned to the top of
the icon, which left a bit of space beneath the text and it looked more natural
not to have a top inset on the content.

It broke the footnote view because that view reuses the content margins
(actually, I'm to blame for this).

This patch is probably a better way to fix this. Here's the before/after*:
https://screenshot.googleplex.com/06FAiVTtoGS.png

*I had to increase the width of the bubble to make the title fit on one line,
since "Chromium" is longer than "Chrome". Here's what it actually ends up
looking like without the extra horizontal space (title therefore wrapping): 
https://screenshot.googleplex.com/5rBVxuX7qOr.png

-  set_margins(gfx::Insets(0, insets.left(), insets.bottom(), insets.right()));
-
   std::unique_ptr<views::BoxLayout> layout(
       new views::BoxLayout(views::BoxLayout::kVertical, 0, 0,
                            views::kRelatedControlVerticalSpacing));
   // Indent by the size of the icon.
   layout->set_inside_border_insets(gfx::Insets(
       0, GetIconSize().width() + views::kUnrelatedControlHorizontalSpacing, 0,
       0));
   SetLayoutManager(layout.release());
 
   if (controller_->options() & ExtensionInstalledBubble::HOW_TO_USE)
@@ skipping 110 matching lines @@
             ->browser_actions();
     return !container->animating();
   }
   return true;
 }
 
 // Implemented here to create the platform specific instance of the BubbleUi.
 std::unique_ptr<BubbleUi> ExtensionInstalledBubble::BuildBubbleUi() {
   return base::WrapUnique(new ExtensionInstalledBubbleUi(this));
 }