third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp - Issue 1950763002: Remove abstractions around GLuint and GL constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp

Issue 1950763002: Remove abstractions around GLuint and GL constants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLActiveInfo.h ('k') | third_party/WebKit/Source/modules/webgl/WebGLFramebuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp b/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp

index fed31b9d42f8fb1a4ce32c53034f9df61ea3aa37..193c9b2b801e6840743bffa46807c33235b0824f 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLDrawBuffers.cpp

@@ -135,7 +135,7 @@ bool WebGLDrawBuffers::satisfiesWebGLRequirements(WebGLRenderingContextBase* web

gl->TexImage2D(GL_TEXTURE_2D, 0, GL_DEPTH_COMPONENT, 1, 1, 0, GL_DEPTH_COMPONENT, GL_UNSIGNED_INT, buffer);

}

- Vector<Platform3DObject> colors;

+ Vector<GLuint> colors;

bool ok = true;

GLint maxAllowedBuffers = std::min(maxDrawBuffers, maxColorAttachments);

for (GLint i = 0; i < maxAllowedBuffers; ++i) {