Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1950633002: Remove IOObservers from MessageLoopForIO. (Closed)

Created:
4 years, 7 months ago by fdoray
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews, sadrul, robliao, gab
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IOObservers from MessageLoopForIO. IOObservers aren't used anywhere. We plan to redirect Tasks that run on the CACHE thread's MessageLoopForIO to the new base/task_scheduler API. For that, we have to replicate MessageLoopForIO's features in base/task_scheduler. Removing features that aren't used will make this easier. BUG=553459 Committed: https://crrev.com/1d49f3c45fba20437ccaba796784deb3d5242e76 Cr-Commit-Position: refs/heads/master@{#392466}

Patch Set 1 #

Patch Set 2 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -137 lines) Patch
M base/message_loop/message_loop.h View 3 chunks +0 lines, -6 lines 0 comments Download
M base/message_loop/message_loop.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M base/message_loop/message_pump_io_ios.h View 4 chunks +0 lines, -20 lines 0 comments Download
M base/message_loop/message_pump_io_ios.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M base/message_loop/message_pump_libevent.h View 4 chunks +0 lines, -20 lines 0 comments Download
M base/message_loop/message_pump_libevent.cc View 4 chunks +0 lines, -21 lines 0 comments Download
M base/message_loop/message_pump_win.h View 1 5 chunks +0 lines, -23 lines 0 comments Download
M base/message_loop/message_pump_win.cc View 2 chunks +0 lines, -18 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950633002/1
4 years, 7 months ago (2016-05-03 19:56:29 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 21:26:16 UTC) #5
fdoray
thestig@: Can you review this CL? Thanks.
4 years, 7 months ago (2016-05-03 21:28:43 UTC) #7
fdoray
+thakis@: Can you review this CL? (thestig@ is OOO)
4 years, 7 months ago (2016-05-04 20:43:34 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950633002/20001
4 years, 7 months ago (2016-05-05 20:54:11 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-06 00:33:03 UTC) #13
Lei Zhang
lgtm FWIW, this was added in r49188.
4 years, 7 months ago (2016-05-09 20:43:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950633002/20001
4 years, 7 months ago (2016-05-09 21:18:14 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 23:15:11 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 23:16:43 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d49f3c45fba20437ccaba796784deb3d5242e76
Cr-Commit-Position: refs/heads/master@{#392466}

Powered by Google App Engine
This is Rietveld 408576698