Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1950623002: Fix IterateCompiledFrame for embedded constant pools. (Closed)

Created:
4 years, 7 months ago by MTBrandyberry
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix IterateCompiledFrame for embedded constant pools. Do not visit the constant pool pointer frame slot. TEST=cctest/test-api/Regress137496 --ignition R=danno@chromium.org, mcilroy@chromium.org, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/88877e55191783978692810bee92135cb305f820 Cr-Commit-Position: refs/heads/master@{#36028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/frames.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
MTBrandyberry
PTAL
4 years, 7 months ago (2016-05-03 19:48:36 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950623002/1
4 years, 7 months ago (2016-05-03 19:50:59 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 20:18:49 UTC) #5
MTBrandyberry
PTAL
4 years, 7 months ago (2016-05-04 15:17:41 UTC) #7
titzer
lgtm
4 years, 7 months ago (2016-05-04 15:40:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950623002/1
4 years, 7 months ago (2016-05-04 15:43:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 15:45:08 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 15:46:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88877e55191783978692810bee92135cb305f820
Cr-Commit-Position: refs/heads/master@{#36028}

Powered by Google App Engine
This is Rietveld 408576698