Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/frames.cc

Issue 1950623002: Fix IterateCompiledFrame for embedded constant pools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/frames.h" 5 #include "src/frames.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/ast/ast.h" 9 #include "src/ast/ast.h"
10 #include "src/ast/scopeinfo.h" 10 #include "src/ast/scopeinfo.h"
(...skipping 700 matching lines...) Expand 10 before | Expand all | Expand 10 after
711 case NUMBER_OF_TYPES: 711 case NUMBER_OF_TYPES:
712 case MANUAL: 712 case MANUAL:
713 UNREACHABLE(); 713 UNREACHABLE();
714 break; 714 break;
715 } 715 }
716 } 716 }
717 slot_space -= 717 slot_space -=
718 (frame_header_size + StandardFrameConstants::kFixedFrameSizeAboveFp); 718 (frame_header_size + StandardFrameConstants::kFixedFrameSizeAboveFp);
719 719
720 Object** frame_header_base = &Memory::Object_at(fp() - frame_header_size); 720 Object** frame_header_base = &Memory::Object_at(fp() - frame_header_size);
721 Object** frame_header_limit = &Memory::Object_at(fp()); 721 Object** frame_header_limit =
722 &Memory::Object_at(fp() - StandardFrameConstants::kCPSlotSize);
722 Object** parameters_base = &Memory::Object_at(sp()); 723 Object** parameters_base = &Memory::Object_at(sp());
723 Object** parameters_limit = frame_header_base - slot_space / kPointerSize; 724 Object** parameters_limit = frame_header_base - slot_space / kPointerSize;
724 725
725 // Visit the parameters that may be on top of the saved registers. 726 // Visit the parameters that may be on top of the saved registers.
726 if (safepoint_entry.argument_count() > 0) { 727 if (safepoint_entry.argument_count() > 0) {
727 v->VisitPointers(parameters_base, 728 v->VisitPointers(parameters_base,
728 parameters_base + safepoint_entry.argument_count()); 729 parameters_base + safepoint_entry.argument_count());
729 parameters_base += safepoint_entry.argument_count(); 730 parameters_base += safepoint_entry.argument_count();
730 } 731 }
731 732
(...skipping 1066 matching lines...) Expand 10 before | Expand all | Expand 10 after
1798 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) { 1799 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) {
1799 StackFrame* frame = AllocateFrameCopy(it.frame(), zone); 1800 StackFrame* frame = AllocateFrameCopy(it.frame(), zone);
1800 list.Add(frame, zone); 1801 list.Add(frame, zone);
1801 } 1802 }
1802 return list.ToVector(); 1803 return list.ToVector();
1803 } 1804 }
1804 1805
1805 1806
1806 } // namespace internal 1807 } // namespace internal
1807 } // namespace v8 1808 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698