 Chromium Code Reviews
 Chromium Code Reviews Issue 1950613005:
  Fixes tests that use internals.observeGC to work with Ignition.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1950613005:
  Fixes tests that use internals.observeGC to work with Ignition.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html | 
| diff --git a/third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html b/third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html | 
| index 06e65c066f443b795aa844588804f375c755b69a..8ebf2896b326434079e6cf31ade0712d488c0e21 100644 | 
| --- a/third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html | 
| +++ b/third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html | 
| @@ -3,13 +3,17 @@ | 
| <input id='text' type='text'></input> | 
| <script src="../../resources/js-test.js"></script> | 
| + <script src="../../resources/observeGCWrapper.js"></script> | 
| <script> | 
| var input = document.getElementById('text'); | 
| input.focus(); | 
| textInputController.setMarkedText("hello", 0, 5); | 
| - var markedRangeResultGC = internals.observeGC(textInputController.markedRange()); | 
| - var selectedRangeResultGC = internals.observeGC(textInputController.selectedRange()); | 
| - var firstRectForCharacterRangeGC = internals.observeGC(textInputController.firstRectForCharacterRange(0, 0)); | 
| + var markedRangeResultGC = callObserveGC(() => { | 
| + return textInputController.markedRange();}); | 
| 
rmcilroy
2016/05/12 09:31:18
nit - '});' on newline.
 | 
| + var selectedRangeResultGC = callObserveGC(() => { | 
| + return textInputController.selectedRange();}); | 
| + var firstRectForCharacterRangeGC = callObserveGC(() => { | 
| + return textInputController.firstRectForCharacterRange(0, 0);}); | 
| gc(); | 
| shouldBeTrue('markedRangeResultGC.wasCollected'); | 
| shouldBeTrue('selectedRangeResultGC.wasCollected'); |