third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html - Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html

Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed line couloum width. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/MutationObserver/weak-callback-gc-crash.html » ('j') | third_party/WebKit/LayoutTests/resources/observeGCWrapper.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <body>	2 <body>

3 <input id='text' type='text'></input>	3 <input id='text' type='text'></input>

4	4

5 <script src="../../resources/js-test.js"></script>	5 <script src="../../resources/js-test.js"></script>

	6 <script src="../../resources/observeGCWrapper.js"></script>

6 <script>	7 <script>

7 var input = document.getElementById('text');	8 var input = document.getElementById('text');

8 input.focus();	9 input.focus();

9 textInputController.setMarkedText("hello", 0, 5);	10 textInputController.setMarkedText("hello", 0, 5);

10 var markedRangeResultGC = internals.observeGC(textInputController.marked Range());	11 var markedRangeResultGC = callObserveGC(() => {

11 var selectedRangeResultGC = internals.observeGC(textInputController.sele ctedRange());	12 return textInputController.markedRange();});
	rmcilroy 2016/05/12 09:31:18 nit - '});' on newline. nit - '});' on newline.
12 var firstRectForCharacterRangeGC = internals.observeGC(textInputControll er.firstRectForCharacterRange(0, 0));	13 var selectedRangeResultGC = callObserveGC(() => {

	14 return textInputController.selectedRange();});

	15 var firstRectForCharacterRangeGC = callObserveGC(() => {

	16 return textInputController.firstRectForCharacterRange(0, 0);});

13 gc();	17 gc();

14 shouldBeTrue('markedRangeResultGC.wasCollected');	18 shouldBeTrue('markedRangeResultGC.wasCollected');

15 shouldBeTrue('selectedRangeResultGC.wasCollected');	19 shouldBeTrue('selectedRangeResultGC.wasCollected');

16 shouldBeTrue('firstRectForCharacterRangeGC.wasCollected');	20 shouldBeTrue('firstRectForCharacterRangeGC.wasCollected');

17 </script>	21 </script>

18 </body>	22 </body>

19 </html>	23 </html>

OLD	NEW