Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html

Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed special wrapper for internals.observeGC. Adds an inner function to pass the object. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html
diff --git a/third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html b/third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html
index 06e65c066f443b795aa844588804f375c755b69a..cc74c3d30184c09eba48f2dfcb50b61a9ce1ce82 100644
--- a/third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html
+++ b/third_party/WebKit/LayoutTests/editing/input/text-input-controller-leak-document.html
@@ -7,9 +7,19 @@
var input = document.getElementById('text');
input.focus();
textInputController.setMarkedText("hello", 0, 5);
- var markedRangeResultGC = internals.observeGC(textInputController.markedRange());
- var selectedRangeResultGC = internals.observeGC(textInputController.selectedRange());
- var firstRectForCharacterRangeGC = internals.observeGC(textInputController.firstRectForCharacterRange(0, 0));
+ // Do not pass the object directly to observeGC function. This may
+ // remain live on this function's stack preventing GC from collecting
+ // it. Accessing the object inside an inner function will prevent any
+ // unneeded references on this function's stack.
+ var markedRangeResultGC = internals.observeGC((() => {
+ return textInputController.markedRange();
+ })());
+ var selectedRangeResultGC = internals.observeGC((() => {
+ return textInputController.selectedRange();
+ })());
+ var firstRectForCharacterRangeGC = internals.observeGC((() => {
+ return textInputController.firstRectForCharacterRange(0, 0);
+ })());
gc();
shouldBeTrue('markedRangeResultGC.wasCollected');
shouldBeTrue('selectedRangeResultGC.wasCollected');
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698