Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html

Issue 1950613005: Fixes tests that use internals.observeGC to work with Ignition. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed special wrapper for internals.observeGC. Adds an inner function to pass the object. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html
diff --git a/third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html b/third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html
index 96fe55a72d4b4bb46c6bc779903bb03290ec671f..7b5d83fc727ccdb3a207ec910907da2711614c69 100644
--- a/third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/NodeIterator/NodeIterator-dont-overcollect.html
@@ -11,10 +11,14 @@
};
var nodeIterator = document.createNodeIterator(document, NodeFilter.SHOW_ELEMENT, callback, false);
- var callbackObservation = internals.observeGC(callback);
+ // Do not pass the object as a parameter to observeGC function. This may
+ // remain live on this function's stack preventing GC from collecting
+ // it. Accessing the object inside an inner function will prevent any
+ // unneeded references on this function's stack.
+ var callbackObservation = internals.observeGC((() => {return callback;})());
callback = null;
- var nodeFilterObservation = internals.observeGC(nodeIterator.filter);
- var nodeIteratorObservation = internals.observeGC(nodeIterator);
+ var nodeFilterObservation = internals.observeGC((() => {return nodeIterator.filter;})());
+ var nodeIteratorObservation = internals.observeGC((() => {return nodeIterator;})());
gc();
shouldBeFalse('nodeFilterObservation.wasCollected');

Powered by Google App Engine
This is Rietveld 408576698