Fix bounds clamping during composited smooth scroll.

Fix bounds clamping during composited smooth scroll.

Also improve handling of nop UpdateTarget.

BUG=609178
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/4d7f47cc84c9b52774814419791ad774536e5cfd
Cr-Commit-Position: refs/heads/master@{#391652}

[skobes, 2016-05-04 18:41:09]

Description was changed from

==========
Fix bounds clamping during composited smooth scroll.

Also improve handling of nop UpdateTarget.

BUG=609178
==========

to

==========
Fix bounds clamping during composited smooth scroll.

Also improve handling of nop UpdateTarget.

BUG=609178
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[skobes, 2016-05-04 19:31:26]

skobes@chromium.org changed reviewers:
+ ymalik@chromium.org

[ymalik, 2016-05-04 20:11:02]

lgtm, as a note

Do you think its possible to plumb the scroll bounds for a particular scroll
offset animation into ScrollOffsetAnimationCurve? I will run into a similar
problem when I try to adjust the initial and target offset by the adjustment
made from scroll anchoring? If the curve itself knew of its max bounds, it would
simply things by not having to worry about clamping before updating.

[skobes, 2016-05-04 20:16:44]

On 2016/05/04 20:11:02, ymalik1 wrote:
> lgtm, as a note
> 
> Do you think its possible to plumb the scroll bounds for a particular scroll
> offset animation into ScrollOffsetAnimationCurve? I will run into a similar
> problem when I try to adjust the initial and target offset by the adjustment
> made from scroll anchoring? If the curve itself knew of its max bounds, it
would
> simply things by not having to worry about clamping before updating.

The bounds can change during the animation, so I don't see much value in storing
them in the curve.  It would be more complicated to keep them updated than to
clamp in LayerImpl.

The scroll anchoring adjustments should respect the bounds at the time of the
adjustment, but that seems easy to do.

[skobes, 2016-05-04 20:18:18]

skobes@chromium.org changed reviewers:
+ ajuma@chromium.org

[skobes, 2016-05-04 20:18:19]

+ajuma for OWNERS

[ajuma, 2016-05-04 21:20:20]

lgtm

[skobes, 2016-05-04 21:25:49]

The CQ bit was checked by skobes@chromium.org

[commit-bot: I haz the power, 2016-05-04 21:26:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950613004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950613004/20001

[commit-bot: I haz the power, 2016-05-04 22:05:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-04 22:07:20]

Description was changed from

==========
Fix bounds clamping during composited smooth scroll.

Also improve handling of nop UpdateTarget.

BUG=609178
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Fix bounds clamping during composited smooth scroll.

Also improve handling of nop UpdateTarget.

BUG=609178
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/4d7f47cc84c9b52774814419791ad774536e5cfd
Cr-Commit-Position: refs/heads/master@{#391652}
==========

[commit-bot: I haz the power, 2016-05-04 22:07:21]

Patchset 2 (id:??) landed as
https://crrev.com/4d7f47cc84c9b52774814419791ad774536e5cfd
Cr-Commit-Position: refs/heads/master@{#391652}