cc/animation/scroll_offset_animations_impl.cc - Issue 1950613004: Fix bounds clamping during composited smooth scroll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/scroll_offset_animations_impl.cc

Issue 1950613004: Fix bounds clamping during composited smooth scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add unit test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/animation/scroll_offset_animations_impl.cc

diff --git a/cc/animation/scroll_offset_animations_impl.cc b/cc/animation/scroll_offset_animations_impl.cc

index ffebdbcd5e76bdae3f1666dfd8f9384d4235b25d..ba7d1801d29f914bf41f8ae0604c5f8cd400de2f 100644

--- a/cc/animation/scroll_offset_animations_impl.cc

+++ b/cc/animation/scroll_offset_animations_impl.cc

@@ -74,6 +74,8 @@ bool ScrollOffsetAnimationsImpl::ScrollAnimationUpdateTarget(

scroll_offset_animation_player_->DetachElement();

return false;

}

+ if (scroll_delta.IsZero())

+ return true;

ScrollOffsetAnimationCurve* curve =

animation->curve()->ToScrollOffsetAnimationCurve();

« no previous file with comments | « cc/animation/scroll_offset_animation_curve.cc ('k') | cc/layers/layer_impl.cc » ('j') | no next file with comments »