Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 1950243002: Do not evaluate on-demand to prevent breaking the deferred loading task (Closed)

Created:
4 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 7 months ago
Reviewers:
Johnni Winther, sra1
CC:
reviews_dartlang.org, Johnni Winther
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : also run dartfmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -11 lines) Patch
M pkg/compiler/lib/src/deferred_load.dart View 1 1 chunk +8 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 1 chunk +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/compiler/dart2js_extra/deferred/deferred_constant_dependency_evaluation_test.dart View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Siggi Cherem (dart-lang)
4 years, 7 months ago (2016-05-05 01:13:53 UTC) #3
sra1
lgtm
4 years, 7 months ago (2016-05-05 01:20:22 UTC) #4
Siggi Cherem (dart-lang)
thx!
4 years, 7 months ago (2016-05-05 01:21:24 UTC) #5
Siggi Cherem (dart-lang)
Committed patchset #2 (id:40001) manually as ed9826894a37deb8c0e1b19dc02120b5779f6ede (presubmit successful).
4 years, 7 months ago (2016-05-05 01:23:44 UTC) #7
Johnni Winther
4 years, 7 months ago (2016-05-09 07:40:32 UTC) #9
Message was sent while issue was closed.
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698