Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: tests/compiler/dart2js_extra/deferred/deferred_constant_dependency_evaluation_test.dart

Issue 1950243002: Do not evaluate on-demand to prevent breaking the deferred loading task (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: also run dartfmt Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tests/compiler/dart2js/dart2js.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 // This is a regression test for dartbug.com/26406. We test that the deferred
6 // loader analyzer doesn't trip over constant expression evaluation.
7 //
8 // Today the task uses constant values to calculate dependencies, and only uses
9 // those values that were previously computed by resolution. A change to compute
10 // the value on-demmand made the deferred task evaluate more expressions,
11 // including expressions with free variables (which can't be evaluated). See the
12 // dartbug.com/26406 for details on how we plan to make the task more robust.
13
14 // import is only used to trigger the deferred task
15 import 'deferred_class_library.dart' deferred as lib;
16
17 class A {
18 final int x;
19
20 const A(bool foo)
21 // The deferred task would crash trying to compute the value here, where
22 // [foo] is a free variable.
23 : x = foo ? 1 : 0;
24 }
25
26 main() => const A(true);
OLDNEW
« no previous file with comments | « tests/compiler/dart2js/dart2js.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698