Remove unused imports in webkitpy with using autoflake.

Remove unused imports in webkitpy with using autoflake.

This is a slightly more conservative re-do of
https://codereview.chromium.org/1847613002.

For this CL, I ran `autoflake -r -i webkitpy` and then undid any changes
to anything in thirdparty or __init__.py files (which can be dealt
with separately).

After https://codereview.chromium.org/1847613002, the
problem that happened was due to removing the imports in
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/__init__.py,
which made it so that multicommandtool was unable to find the subclasses
of Command, which broke webkit-patch (which is used by the auto-rebaseline
bot).

This CL doesn't remove anything from webkitpy/tool/commands/__init__.py
or webkitpy/tool/main.py.

BUG=598897
Committed: https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76
Cr-Commit-Position: refs/heads/master@{#393077}

[qyearsley, 2016-05-04 22:32:45]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-05-06 00:58:49]

it seems like, in addition to removing unused imports, this has two additional
side effects:

- it seems to split `from ... import foo, bar` into two lines
- it deletes "unneeded" pass lines.

I would just as soon not make either of those changes, as I don't think they're
necessarily improving readability.

How easy is it to do that?

[qyearsley, 2016-05-06 16:35:55]

On 2016/05/06 at 00:58:49, dpranke wrote:
> it seems like, in addition to removing unused imports, this has two additional
side effects:
> 
> - it seems to split `from ... import foo, bar` into two lines
> - it deletes "unneeded" pass lines.
> 
> I would just as soon not make either of those changes, as I don't think
they're necessarily improving readability.
> 
> How easy is it to do that?

Not super easy, since autoflake doesn't have an option to change that behavior,
AFAIK. But I could manually re-add pass lines etc.

[qyearsley, 2016-05-09 18:30:13]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 18:30:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950213002/20001

[qyearsley, 2016-05-09 18:31:12]

On 2016/05/06 at 16:35:55, qyearsley wrote:
> On 2016/05/06 at 00:58:49, dpranke wrote:
> > it seems like, in addition to removing unused imports, this has two
additional side effects:
> > 
> > - it seems to split `from ... import foo, bar` into two lines
> > - it deletes "unneeded" pass lines.
> > 
> > I would just as soon not make either of those changes, as I don't think
they're necessarily improving readability.
> > 
> > How easy is it to do that?
> 
> Not super easy, since autoflake doesn't have an option to change that
behavior, AFAIK. But I could manually re-add pass lines etc.

Now I've re-added the pass statements so this CL should only touch import
statements. With regard to splitting import statements into multiple lines, I'm
a bit in favor of splitting into multiple lines just because I'm used to that
now :-P

Anyway, there are now feature requests in the autoflake issue tracker:
 * https://github.com/myint/autoflake/issues/10 Add an option to not remove
useless pass statements
 * https://github.com/myint/autoflake/issues/7 Add an option to not split into
multiple lines

OK to try to submit now?

[commit-bot: I haz the power, 2016-05-09 19:47:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 19:47:12]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-05-10 22:11:02]

lgtm. I'm not sure why it thinks you should only import one object per line, but
I don't feel that strongly about it.

[wkorman, 2016-05-10 22:14:03]

wkorman@chromium.org changed reviewers:
+ wkorman@chromium.org

[wkorman, 2016-05-10 22:14:03]

lgtm

Can you make sure that you are able to run:

./Tools/Scripts/webkit-patch auto-rebaseline -v <some test>

with this patch without error before submit?

[qyearsley, 2016-05-11 17:49:13]

On 2016/05/10 at 22:14:03, wkorman wrote:
> lgtm
> 
> Can you make sure that you are able to run:
> 
> ./Tools/Scripts/webkit-patch auto-rebaseline -v <some test>
> 
> with this patch without error before submit?

Tried this with multiple tests, didn't find any problems; will now try to
submit.

[qyearsley, 2016-05-11 17:49:18]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-05-11 17:49:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950213002/20001

[commit-bot: I haz the power, 2016-05-11 17:53:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 17:53:48]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[qyearsley, 2016-05-11 20:44:53]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-05-11 20:44:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/1950213002/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-05-11 20:45:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950213002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950213002/40001

[commit-bot: I haz the power, 2016-05-11 21:54:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-11 21:55:06]

Description was changed from

==========
Remove unused imports in webkitpy with using autoflake.

This is a slightly more conservative re-do of
https://codereview.chromium.org/1847613002.

For this CL, I ran `autoflake -r -i webkitpy` and then undid any changes
to anything in thirdparty or __init__.py files (which can be dealt
with separately).

After https://codereview.chromium.org/1847613002, the
problem that happened was due to removing the imports in
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/__init__.py,
which made it so that multicommandtool was unable to find the subclasses
of Command, which broke webkit-patch (which is used by the auto-rebaseline
bot).

This CL doesn't remove anything from webkitpy/tool/commands/__init__.py
or webkitpy/tool/main.py.

BUG=598897
==========

to

==========
Remove unused imports in webkitpy with using autoflake.

This is a slightly more conservative re-do of
https://codereview.chromium.org/1847613002.

For this CL, I ran `autoflake -r -i webkitpy` and then undid any changes
to anything in thirdparty or __init__.py files (which can be dealt
with separately).

After https://codereview.chromium.org/1847613002, the
problem that happened was due to removing the imports in
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/__init__.py,
which made it so that multicommandtool was unable to find the subclasses
of Command, which broke webkit-patch (which is used by the auto-rebaseline
bot).

This CL doesn't remove anything from webkitpy/tool/commands/__init__.py
or webkitpy/tool/main.py.

BUG=598897

Committed: https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76
Cr-Commit-Position: refs/heads/master@{#393077}
==========

[commit-bot: I haz the power, 2016-05-11 21:55:08]

Patchset 3 (id:??) landed as
https://crrev.com/33305ad2a855ad0269e5b33bc1948e8c7d8e7a76
Cr-Commit-Position: refs/heads/master@{#393077}