Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1847613002: Remove unused imports in webkitpy. (Closed)

Created:
4 years, 8 months ago by qyearsley
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, ojan
CC:
blink-reviews, blink-reviews-style_chromium.org, blink-reviews-w3ctests_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused imports in webkitpy. This was done with `autoflake -i --remove-all-unused-imports`, with minor editing afterwards, including in common/net/__init__.py, where importing is done in order to expose a public API. BUG=598897 Committed: https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517 Cr-Commit-Position: refs/heads/master@{#384300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -183 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/bindings/main.py View 2 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/host.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/message_pool.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/file_uploader.py View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/networktransaction_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive.py View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_unittest.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/logutils_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/outputtee_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/path.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/path_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/platforminfo_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/stack_utils_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/bisect_test_ordering.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/breakpad/dump_reader_multipart_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/generate_results_dashboard.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 1 chunk +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_driver_unittest.py View 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/browser_test_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mac_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 2 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/test.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/process_json_data_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/apache_http_unittest.py View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/cli_wrapper_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing_unittest.py View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest.py View 1 chunk +1 line, -10 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/performance_tests/perftest_unittest.py View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checker_unittest.py View 3 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/png.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/error_handlers.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/filereader_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/style/optparser.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/__init__.py View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/commitannouncer.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests.py View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/flakytests_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/main.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/mocktool.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/layouttestsserver.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/reflectionhandler.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/steps/__init__.py View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/steps/abstractstep.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
qyearsley
4 years, 8 months ago (2016-03-30 17:54:20 UTC) #2
Dirk Pranke
lgtm
4 years, 8 months ago (2016-03-31 02:06:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847613002/1
4 years, 8 months ago (2016-03-31 15:10:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 16:17:07 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b6a8ce44839c159ddfd9090db7ba88f89d6ef517 Cr-Commit-Position: refs/heads/master@{#384300}
4 years, 8 months ago (2016-03-31 16:20:07 UTC) #10
wkorman
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1846093002/ by wkorman@chromium.org. ...
4 years, 8 months ago (2016-03-31 23:36:58 UTC) #11
qyearsley
4 years, 8 months ago (2016-04-01 05:04:41 UTC) #12
Message was sent while issue was closed.
On 2016/03/31 at 23:36:58, wkorman wrote:
> A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1846093002/ by wkorman@chromium.org.
> 
> The reason for reverting is: http://crbug.com/599579 - Breaks auto-rebaseline
bot..

This CL shouldn't have made any changes to any of the __init__.py files, which
in general expose public classes and methods so they can be imported elsewhere;
the change that broke the rebaseline bot may have been removing imports in
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/__init__.py.

Powered by Google App Engine
This is Rietveld 408576698