Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 1950133003: Update String methods. (Closed)

Created:
4 years, 7 months ago by sra1
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update String methods. This will need a second pass after core.Iterable is updated and JS type strings are better parsed. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/1400d063fb91ec96b541f7cdbe6e23f972fc19e8

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+426 lines, -207 lines) Patch
M lib/runtime/dart_sdk.js View 17 chunks +207 lines, -117 lines 0 comments Download
M tool/input_sdk/lib/core/string.dart View 5 chunks +31 lines, -5 lines 0 comments Download
M tool/input_sdk/private/js_helper.dart View 1 chunk +4 lines, -1 line 0 comments Download
M tool/input_sdk/private/js_rti.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tool/input_sdk/private/js_string.dart View 8 chunks +28 lines, -14 lines 0 comments Download
M tool/input_sdk/private/string_helper.dart View 8 chunks +149 lines, -63 lines 0 comments Download
M tool/sdk_expected_errors.txt View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
sra1
4 years, 7 months ago (2016-05-05 02:25:10 UTC) #4
vsm
lgtm
4 years, 7 months ago (2016-05-05 02:36:03 UTC) #5
sra1
4 years, 7 months ago (2016-05-05 02:41:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
1400d063fb91ec96b541f7cdbe6e23f972fc19e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698