Update String methods.

tool/input_sdk/private/js_string.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart._interceptors;
 
 /**
  * The interceptor class for [String]. The compiler recognizes this
  * class as an interceptor, and changes references to [:this:] to
  * actually use the receiver of the method, which is generated as an extra
  * argument added to each member.
  */
 @JsPeerInterface(name: 'String')
 class JSString extends Interceptor implements String, JSIndexable {
   const JSString();
 
   int codeUnitAt(int index) {
-    if (index is !int) throw new ArgumentError(index);
-    if (index < 0) throw new RangeError.value(index);
-    if (index >= length) throw new RangeError.value(index);
+    if (index is !int) throw diagnoseIndexError(this, index);
+    if (index < 0) throw diagnoseIndexError(this, index);
+    if (index >= length) throw diagnoseIndexError(this, index);
     return JS('int', r'#.charCodeAt(#)', this, index);
   }
 
   Iterable<Match> allMatches(String string, [int start = 0]) {
     checkString(string);
     checkInt(start);
     if (0 > start || start > string.length) {
       throw new RangeError.range(start, 0, string.length);
     }
     return allMatchesInStringUnchecked(this, string, start);
   }
 
   Match matchAsPrefix(String string, [int start = 0]) {
     if (start < 0 || start > string.length) {
       throw new RangeError.range(start, 0, string.length);
     }
     if (start + this.length > string.length) return null;
     // TODO(lrn): See if this can be optimized.
     for (int i = 0; i < this.length; i++) {
       if (string.codeUnitAt(start + i) != this.codeUnitAt(i)) {
         return null;
       }
     }
     return new StringMatch(start, string, this);
   }
 
   String operator +(String other) {
-    if (other is !String) throw new ArgumentError(other);
+    if (other is !String) throw new ArgumentError.value(other);
     return JS('String', r'# + #', this, other);
   }
 
   bool endsWith(String other) {
     checkString(other);
     int otherLength = other.length;
     if (otherLength > length) return false;
     return other == substring(length - otherLength);
   }
 
   String replaceAll(Pattern from, String to) {
     checkString(to);
     return stringReplaceAllUnchecked(this, from, to);
   }
 
   String replaceAllMapped(Pattern from, String convert(Match match)) {
     return this.splitMapJoin(from, onMatch: convert);
   }
 
   String splitMapJoin(Pattern from,
                       {String onMatch(Match match),
                        String onNonMatch(String nonMatch)}) {
     return stringReplaceAllFuncUnchecked(this, from, onMatch, onNonMatch);
   }
 
   String replaceFirst(Pattern from, String to, [int startIndex = 0]) {
     checkString(to);
     checkInt(startIndex);
-    if (startIndex < 0 || startIndex > this.length) {
-      throw new RangeError.range(startIndex, 0, this.length);
-    }
+    RangeError.checkValueInInterval(startIndex, 0, this.length, "startIndex");
     return stringReplaceFirstUnchecked(this, from, to, startIndex);
   }
 
+  String replaceFirstMapped(Pattern from, String replace(Match match),
+                            [int startIndex = 0]) {
+    checkNull(replace);
+    checkInt(startIndex);
+    RangeError.checkValueInInterval(startIndex, 0, this.length, "startIndex");
+    return stringReplaceFirstMappedUnchecked(this, from, replace, startIndex);
+  }
+
   List<String> split(Pattern pattern) {
     checkNull(pattern);
     if (pattern is String) {
       return JS('JSExtendableArray', r'#.split(#)', this, pattern);
     } else if (pattern is JSSyntaxRegExp && regExpCaptureCount(pattern) == 0) {
       var re = regExpGetNative(pattern);
       return JS('JSExtendableArray', r'#.split(#)', this, re);
     } else {
       return _defaultSplit(pattern);
     }
   }
 
+  String replaceRange(int start, int end, String replacement) {
+    checkString(replacement);
+    checkInt(start);
+    end = RangeError.checkValidRange(start, end, this.length);
+    checkInt(end);
+    return stringReplaceRangeUnchecked(this, start, end, replacement);
+  }
+
   List<String> _defaultSplit(Pattern pattern) {
     List<String> result = <String>[];
     // End of most recent match. That is, start of next part to add to result.
     int start = 0;
     // Length of most recent match.
     // Set >0, so no match on the empty string causes the result to be [""].
     int length = 1;
     for (var match in pattern.allMatches(this)) {
       int matchStart = match.start;
       int matchEnd = match.end;
@@ skipping 254 matching lines @@
     if (delta <= 0) return this;
     return this + padding * delta;
   }
 
   List<int> get codeUnits => new _CodeUnits(this);
 
   Runes get runes => new Runes(this);
 
   int indexOf(Pattern pattern, [int start = 0]) {
     checkNull(pattern);
-    if (start is! int) throw new ArgumentError(start);
+    if (start is! int) throw argumentErrorValue(start);
     if (start < 0 || start > this.length) {
       throw new RangeError.range(start, 0, this.length);
     }
     if (pattern is String) {
-      return JS('int', r'#.indexOf(#, #)', this, pattern, start);
+      return stringIndexOfStringUnchecked(this, pattern, start);
     }
     if (pattern is JSSyntaxRegExp) {
       JSSyntaxRegExp re = pattern;
       Match match = firstMatchAfter(re, this, start);
       return (match == null) ? -1 : match.start;
     }
     for (int i = start; i <= this.length; i++) {
       if (pattern.matchAsPrefix(this, i) != null) return i;
     }
     return -1;
   }
 
   int lastIndexOf(Pattern pattern, [int start]) {
     checkNull(pattern);
     if (start == null) {
       start = length;
     } else if (start is! int) {
-      throw new ArgumentError(start);
+      throw argumentErrorValue(start);
     } else if (start < 0 || start > this.length) {
       throw new RangeError.range(start, 0, this.length);
     }
     if (pattern is String) {
       String other = pattern;
       if (start + other.length > this.length) {
         start = this.length - other.length;
       }
       return stringLastIndexOfUnchecked(this, other, start);
     }
     for (int i = start; i >= 0; i--) {
       if (pattern.matchAsPrefix(this, i) != null) return i;
     }
     return -1;
   }
 
   bool contains(Pattern other, [int startIndex = 0]) {
     checkNull(other);
     if (startIndex < 0 || startIndex > this.length) {
       throw new RangeError.range(startIndex, 0, this.length);
     }
     return stringContainsUnchecked(this, other, startIndex);
   }
 
   bool get isEmpty => length == 0;
 
   bool get isNotEmpty => !isEmpty;
 
   int compareTo(String other) {
-    if (other is !String) throw new ArgumentError(other);
+    if (other is !String) throw argumentErrorValue(other);
     return this == other ? 0
-      : JS('bool', r'# < #', this, other) ? -1 : 1;
+        : JS('bool', r'# < #', this, other) ? -1 : 1;
   }
 
   // Note: if you change this, also change the function [S].
   String toString() => this;
 
   /**
    * This is the [Jenkins hash function][1] but using masking to keep
    * values in SMI range.
    *
    * [1]: http://en.wikipedia.org/wiki/Jenkins_hash_function
@@ skipping 10 matching lines @@
     hash = 0x1fffffff & (hash + ((0x03ffffff & hash) <<  3));
     hash = JS('int', '# ^ (# >> 11)', hash, hash);
     return 0x1fffffff & (hash + ((0x00003fff & hash) << 15));
   }
 
   Type get runtimeType => String;
 
   int get length => JS('int', r'#.length', this);
 
   String operator [](int index) {
-    if (index is !int) throw new ArgumentError(index);
-    if (index >= length || index < 0) throw new RangeError.value(index);
+    if (index is !int) throw diagnoseIndexError(this, index);
+    if (index >= length || index < 0) throw diagnoseIndexError(this, index);
     return JS('String', '#[#]', this, index);
   }
 }
 
 /**
  * An [Iterable] of the UTF-16 code units of a [String] in index order.
  */
 class _CodeUnits extends UnmodifiableListBase<int> {
   /** The string that this is the code units of. */
   String _string;
 
   _CodeUnits(this._string);
 
   int get length => _string.length;
   int operator[](int i) => _string.codeUnitAt(i);
 }