Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: appengine/findit/crash/fracas_parser.py

Issue 1950123003: [Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Update doc string. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/fracas_crash_pipeline.py ('k') | appengine/findit/crash/results.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/fracas_parser.py
diff --git a/appengine/findit/crash/fracas_parser.py b/appengine/findit/crash/fracas_parser.py
index a4b967270c99c7ef55d0f4b71052fca4ce3efef4..51945713cc66003792e65786fbb0dd5b228ebe83 100644
--- a/appengine/findit/crash/fracas_parser.py
+++ b/appengine/findit/crash/fracas_parser.py
@@ -5,6 +5,7 @@
import re
from crash.callstack import CallStack
+from crash.callstack_filters import FilterFramesBeforeSignature
from crash.stacktrace import Stacktrace
from crash.stacktrace_parser import StacktraceParser
from crash.type_enums import CallStackFormatType
@@ -18,7 +19,7 @@ _INFINITY_PRIORITY = 1000
class FracasParser(StacktraceParser):
- def Parse(self, stacktrace_string, deps):
+ def Parse(self, stacktrace_string, deps, signature=None):
"""Parse fracas stacktrace string into Stacktrace instance."""
stacktrace = Stacktrace()
callstack = CallStack(_INFINITY_PRIORITY)
@@ -40,6 +41,8 @@ class FracasParser(StacktraceParser):
if callstack.priority != _INFINITY_PRIORITY and callstack:
stacktrace.append(callstack)
+ # Filter all the frames before signature frame.
+ FilterFramesBeforeSignature(stacktrace.GetCrashStack(), signature)
return stacktrace
def _IsStartOfNewCallStack(self, line):
« no previous file with comments | « appengine/findit/crash/fracas_crash_pipeline.py ('k') | appengine/findit/crash/results.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698