Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1658)

Unified Diff: appengine/findit/crash/fracas_crash_pipeline.py

Issue 1950123003: [Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Update doc string. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/fracas.py ('k') | appengine/findit/crash/fracas_parser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/fracas_crash_pipeline.py
diff --git a/appengine/findit/crash/fracas_crash_pipeline.py b/appengine/findit/crash/fracas_crash_pipeline.py
index 381b3757fe101e54e2906b3caf42150df91eb929..125703a5920743ecd53ae022870983246a5e7bb5 100644
--- a/appengine/findit/crash/fracas_crash_pipeline.py
+++ b/appengine/findit/crash/fracas_crash_pipeline.py
@@ -55,9 +55,8 @@ class FracasAnalysisPipeline(FracasBasePipeline):
# Run the analysis.
result, tags = fracas.FindCulpritForChromeCrash(
- analysis.channel, analysis.platform, analysis.signature,
- analysis.stack_trace, analysis.crashed_version,
- analysis.historic_metadata)
+ analysis.signature, analysis.platform, analysis.stack_trace,
+ analysis.crashed_version, analysis.historic_metadata)
# Update analysis status and save the analysis result.
analysis.completed_time = datetime.datetime.utcnow()
@@ -81,6 +80,7 @@ class PublishResultPipeline(FracasBasePipeline):
analysis = FracasCrashAnalysis.Get(crash_identifiers)
result = {
'crash_identifiers': crash_identifiers,
+ 'client_id': analysis.client_id,
'result': analysis.result,
}
messages_data = [json.dumps(result, sort_keys=True)]
@@ -108,7 +108,6 @@ def _NeedsNewAnalysis(
# A new analysis is not needed if last one didn't complete or succeeded.
# TODO(http://crbug.com/600535): re-analyze if stack trace or regression
# range changed.
- print 'lala'
return False
if not analysis:
« no previous file with comments | « appengine/findit/crash/fracas.py ('k') | appengine/findit/crash/fracas_parser.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698