src/js/array.js - Issue 1950073002: Convert negative zero in ArraySpeciesCreate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/array.js

Issue 1950073002: Convert negative zero in ArraySpeciesCreate (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/array.js

diff --git a/src/js/array.js b/src/js/array.js

index 8c1a0aefa66bcc82ab154b7ab43723f58b284d24..82b4040d600969feca4207425e7bd1ef3b24889e 100644

--- a/src/js/array.js

+++ b/src/js/array.js

@@ -43,6 +43,11 @@ utils.ImportFromExperimental(function(from) {

function ArraySpeciesCreate(array, length) {

var constructor;

+ if (1 / length === -INFINITY) {

+ length = 0;

+ }

Dan Ehrenberg 2016/05/04 16:44:48 A likely faster way to convert -0 to +0 is length

if (FLAG_harmony_species) {

constructor = %ArraySpeciesConstructor(array);

} else {

« no previous file with comments | « no previous file | test/mjsunit/es6/array-species-neg-zero.js » ('j') | no next file with comments »