Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1544)

Issue 1950073002: Convert negative zero in ArraySpeciesCreate (Closed)

Created:
4 years, 7 months ago by mike3
Modified:
4 years, 7 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Convert negative zero in ArraySpeciesCreate As per the ES2015 spec, the value `-0` should be converted to `+0` prior to invocation of the species constructor. BUG=v8:4988 LOG=N R=littledan@chromium.org Committed: https://crrev.com/915ec67cc62edac4abbba6033e9e88f4f395d14f Cr-Commit-Position: refs/heads/master@{#36045}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Incorporate review feedback #

Total comments: 1

Patch Set 3 : Re-use macro in another location #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M src/js/array.js View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M src/js/macros.py View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/es6/array-species-neg-zero.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (2 generated)
mike3
4 years, 7 months ago (2016-05-04 16:39:16 UTC) #1
Dan Ehrenberg
https://codereview.chromium.org/1950073002/diff/1/src/js/array.js File src/js/array.js (right): https://codereview.chromium.org/1950073002/diff/1/src/js/array.js#newcode49 src/js/array.js:49: } A likely faster way to convert -0 to ...
4 years, 7 months ago (2016-05-04 16:44:48 UTC) #2
mike3
On 2016/05/04 16:44:48, Dan Ehrenberg wrote: > https://codereview.chromium.org/1950073002/diff/1/src/js/array.js > File src/js/array.js (right): > > https://codereview.chromium.org/1950073002/diff/1/src/js/array.js#newcode49 ...
4 years, 7 months ago (2016-05-04 16:57:22 UTC) #3
Dan Ehrenberg
On 2016/05/04 at 16:57:22, mike wrote: > On 2016/05/04 16:44:48, Dan Ehrenberg wrote: > > ...
4 years, 7 months ago (2016-05-04 17:14:06 UTC) #4
mike3
On 2016/05/04 17:14:06, Dan Ehrenberg wrote: > On 2016/05/04 at 16:57:22, mike wrote: > > ...
4 years, 7 months ago (2016-05-04 17:27:10 UTC) #5
Dan Ehrenberg
Name bikeshedding: TO_POSITIVE_ZERO? https://codereview.chromium.org/1950073002/diff/20001/src/js/array.js File src/js/array.js (right): https://codereview.chromium.org/1950073002/diff/20001/src/js/array.js#newcode1261 src/js/array.js:1261: index = TO_INTEGER(index) + 0; // ...
4 years, 7 months ago (2016-05-04 17:52:25 UTC) #6
mike3
On 2016/05/04 17:52:25, Dan Ehrenberg wrote: > Name bikeshedding: TO_POSITIVE_ZERO? > > https://codereview.chromium.org/1950073002/diff/20001/src/js/array.js > File ...
4 years, 7 months ago (2016-05-04 18:01:38 UTC) #7
Dan Ehrenberg
lgtm
4 years, 7 months ago (2016-05-04 20:40:57 UTC) #8
Dan Ehrenberg
On 2016/05/04 at 20:40:57, Dan Ehrenberg wrote: > lgtm Good point on the naming.
4 years, 7 months ago (2016-05-04 20:41:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950073002/40001
4 years, 7 months ago (2016-05-04 21:03:18 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-04 21:32:01 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/915ec67cc62edac4abbba6033e9e88f4f395d14f Cr-Commit-Position: refs/heads/master@{#36045}
4 years, 7 months ago (2016-05-04 21:34:01 UTC) #14
mike3
4 years, 7 months ago (2016-05-04 21:40:26 UTC) #15
Message was sent while issue was closed.
On 2016/05/04 21:34:01, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/915ec67cc62edac4abbba6033e9e88f4f395d14f
> Cr-Commit-Position: refs/heads/master@{#36045}

Thanks, Dan!

Powered by Google App Engine
This is Rietveld 408576698