Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1949943003:
Stop banning stroke-and-fill for GrStyle and add tests (Closed)
DescriptionStop banning stroke-and-fill for GrStyle and add tests
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1949943003
Committed: https://skia.googlesource.com/skia/+/f0cf355b55eec7dacaa6c8e87c736e359b3ee278
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 21 (12 generated)
Description was changed from ========== Add support to GrStyle/GrShape for stroke-and-fill styling. ========== to ========== Add support to GrStyle/GrShape for stroke-and-fill styling. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Add support to GrStyle/GrShape for stroke-and-fill styling. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Stop banning stroke-and-fill for GrStyle and add tests GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
bsalomon@google.com changed reviewers: + egdaniel@google.com, robertphillips@google.com
lgtm
The CQ bit was checked by bsalomon@google.com
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 1949193002 Patch 20001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was unchecked by bsalomon@google.com
The CQ bit was checked by bsalomon@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949943003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
The CQ bit was checked by bsalomon@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949943003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
The CQ bit was checked by borenet@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949943003/1
Message was sent while issue was closed.
Description was changed from ========== Stop banning stroke-and-fill for GrStyle and add tests GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Stop banning stroke-and-fill for GrStyle and add tests GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/f0cf355b55eec7dacaa6c8e87c736e359b3ee278 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/f0cf355b55eec7dacaa6c8e87c736e359b3ee278 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
