Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1949193002: Make cap only affect the keys of GrShapes that are possibly-open (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 3

Patch Set 3 : due #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -53 lines) Patch
M src/gpu/GrShape.h View 1 2 chunks +18 lines, -2 lines 0 comments Download
M src/gpu/GrShape.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/GrStyle.h View 1 2 1 chunk +14 lines, -5 lines 0 comments Download
M src/gpu/GrStyle.cpp View 1 3 chunks +11 lines, -3 lines 0 comments Download
M tests/GrShapeTest.cpp View 1 5 chunks +69 lines, -41 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bsalomon
This was in the long tail of possible optimizations to do for GrShape. However, landing ...
4 years, 7 months ago (2016-05-04 20:15:35 UTC) #3
bsalomon
https://codereview.chromium.org/1949193002/diff/20001/src/gpu/GrStyle.h File src/gpu/GrStyle.h (right): https://codereview.chromium.org/1949193002/diff/20001/src/gpu/GrStyle.h#newcode66 src/gpu/GrStyle.h:66: static int KeySize(const GrStyle& , Apply, uint32_t flags = ...
4 years, 7 months ago (2016-05-04 20:17:10 UTC) #4
robertphillips
lgtm https://codereview.chromium.org/1949193002/diff/20001/src/gpu/GrStyle.h File src/gpu/GrStyle.h (right): https://codereview.chromium.org/1949193002/diff/20001/src/gpu/GrStyle.h#newcode51 src/gpu/GrStyle.h:51: /** do to -> due to ?
4 years, 7 months ago (2016-05-04 20:27:00 UTC) #5
bsalomon
https://codereview.chromium.org/1949193002/diff/20001/src/gpu/GrStyle.h File src/gpu/GrStyle.h (right): https://codereview.chromium.org/1949193002/diff/20001/src/gpu/GrStyle.h#newcode51 src/gpu/GrStyle.h:51: /** On 2016/05/04 20:27:00, robertphillips wrote: > do to ...
4 years, 7 months ago (2016-05-04 20:29:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949193002/40001
4 years, 7 months ago (2016-05-04 20:29:35 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 20:50:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/06077565b18714ff3fc0db9118e2c21f6f25243f

Powered by Google App Engine
This is Rietveld 408576698