Issue 1949743002: EDK: HandleTransport::CreateEquivalentDispatcherAndClose() -> CreateEquivalentHandleAndClose().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1949743002: EDK: HandleTransport::CreateEquivalentDispatcherAndClose() -> CreateEquivalentHandleAndClose(). (Closed)

Created:
4 years, 7 months ago by viettrungluu

Modified:
4 years, 7 months ago

Reviewers:
azani

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@work791_edk_handle_12-x-work790_edk_handle_11-x-work788_edk_handle_10

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

EDK: HandleTransport::CreateEquivalentDispatcherAndClose() -> CreateEquivalentHandleAndClose(). I.e., rename the method and make it return a Handle instead of (a ref ptr to) a Dispatcher. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/01cd947354cd5de276a266621fc6be3130281cb5

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -16 lines)			Patch
M	mojo/edk/system/handle_transport.h	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	mojo/edk/system/message_pipe.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	mojo/edk/system/platform_handle_dispatcher_unittest.cc	View	1 chunk	+13 lines, -9 lines	0 comments	Download

Depends on Patchset:

Issue 1947733002 Patch 1

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

4 years, 7 months ago (2016-05-04 02:16:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
01cd947354cd5de276a266621fc6be3130281cb5 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages