Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: mojo/edk/system/message_pipe.cc

Issue 1949743002: EDK: HandleTransport::CreateEquivalentDispatcherAndClose() -> CreateEquivalentHandleAndClose(). (Closed) Base URL: https://github.com/domokit/mojo.git@work791_edk_handle_12-x-work790_edk_handle_11-x-work788_edk_handle_10
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/handle_transport.h ('k') | mojo/edk/system/platform_handle_dispatcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/message_pipe.cc
diff --git a/mojo/edk/system/message_pipe.cc b/mojo/edk/system/message_pipe.cc
index 82b8fd3650be7592d1a5cfa62bcdba30911585c0..ae7de62b4a3a719f0a5d66bc32e875015b7b39f7 100644
--- a/mojo/edk/system/message_pipe.cc
+++ b/mojo/edk/system/message_pipe.cc
@@ -364,8 +364,10 @@ MojoResult MessagePipe::AttachTransportsNoLock(
dispatchers->reserve(transports->size());
for (size_t i = 0; i < transports->size(); i++) {
if ((*transports)[i].is_valid()) {
- dispatchers->push_back(
- (*transports)[i].CreateEquivalentDispatcherAndClose(this, port));
+ // TODO(vtl): Plumb this into |MessageInTransit|. (I.e., |dispatchers| ->
+ // |handles|, etc.)
+ Handle h = (*transports)[i].CreateEquivalentHandleAndClose(this, port);
+ dispatchers->push_back(std::move(h.dispatcher));
} else {
LOG(WARNING) << "Enqueueing null dispatcher";
dispatchers->push_back(nullptr);
« no previous file with comments | « mojo/edk/system/handle_transport.h ('k') | mojo/edk/system/platform_handle_dispatcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698