Issue 1949613004: Properly fix the warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1949613004: Properly fix the warnings (Closed)

Created:
4 years, 7 months ago by Wei Li

Modified:
4 years, 7 months ago

Reviewers:

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

Properly fix the warnings ASSERT(statement) will not execute statement in release builds. So need to move statements outside ASSERT(). TBR=tsepez@chromium.org,dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5fe7ae721a2e843007de69fcf76c252da942440f

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	xfa/fxfa/parser/xfa_object_imp.cpp	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 3 (2 generated)

Wei Li

4 years, 7 months ago (2016-05-05 04:13:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5fe7ae721a2e843007de69fcf76c252da942440f (tree was closed).