Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: xfa/fxfa/parser/xfa_object_imp.cpp

Issue 1949613004: Properly fix the warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxfa/parser/xfa_object_imp.cpp
diff --git a/xfa/fxfa/parser/xfa_object_imp.cpp b/xfa/fxfa/parser/xfa_object_imp.cpp
index 32da7f7a17ee6e80170faaf90635c44fbf00f004..91497a50d02a95b262e172966e11f3ce7d8a3734 100644
--- a/xfa/fxfa/parser/xfa_object_imp.cpp
+++ b/xfa/fxfa/parser/xfa_object_imp.cpp
@@ -4574,7 +4574,8 @@ CXFA_Node* CXFA_Node::GetChild(int32_t index,
int32_t CXFA_Node::InsertChild(int32_t index, CXFA_Node* pNode) {
ASSERT(!pNode->m_pNext);
pNode->m_pParent = this;
- ASSERT(m_pDocument->RemovePurgeNode(pNode));
+ FX_BOOL ret = m_pDocument->RemovePurgeNode(pNode);
+ ASSERT(ret);
if (m_pChild == NULL || index == 0) {
if (index > 0) {
@@ -4622,7 +4623,8 @@ FX_BOOL CXFA_Node::InsertChild(CXFA_Node* pNode, CXFA_Node* pBeforeNode) {
ASSERT(false);
return FALSE;
}
- ASSERT(m_pDocument->RemovePurgeNode(pNode));
+ FX_BOOL ret = m_pDocument->RemovePurgeNode(pNode);
+ ASSERT(ret);
int32_t nIndex = -1;
pNode->m_pParent = this;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698