Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1949603002: Revert of mus: Enable system modal windows (Closed)

Created:
4 years, 7 months ago by Ben Goodger (Google)
Modified:
4 years, 7 months ago
Reviewers:
sky, mohsen
CC:
chromium-reviews, kalyank, rjkroege, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mus: Enable system modal windows (patchset #13 id:240001 of https://codereview.chromium.org/1818333002/ ) Reason for revert: Cases crashes when running mojo_runner mojo:mash_init then selecting a user. ED::UnobserveWindow @ the top of the call stack. Original issue's description: > mus: Enable system modal windows > > When a modal window does not have a transient parent, it will be modal > to the whole system. > > BUG=548402 > > Committed: https://crrev.com/aad86d4a28e819ff7b1d6cef106c7d88da2d48aa > Cr-Commit-Position: refs/heads/master@{#390963} TBR=sky@chromium.org,mohsen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=548402 Committed: https://crrev.com/f0bc2797737fcc29f952ada285eaab16a7f8c21f Cr-Commit-Position: refs/heads/master@{#391301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -565 lines) Patch
M components/mus/public/cpp/lib/window.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 2 chunks +7 lines, -9 lines 0 comments Download
M components/mus/ws/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/mus/ws/event_dispatcher.h View 5 chunks +4 lines, -27 lines 0 comments Download
M components/mus/ws/event_dispatcher.cc View 10 chunks +32 lines, -59 lines 0 comments Download
M components/mus/ws/event_dispatcher_unittest.cc View 5 chunks +5 lines, -127 lines 0 comments Download
D components/mus/ws/modal_window_controller.h View 1 chunk +0 lines, -87 lines 0 comments Download
D components/mus/ws/modal_window_controller.cc View 1 chunk +0 lines, -121 lines 0 comments Download
M components/mus/ws/server_window.h View 2 chunks +12 lines, -2 lines 0 comments Download
M components/mus/ws/server_window.cc View 4 chunks +31 lines, -6 lines 0 comments Download
M components/mus/ws/test_utils.h View 1 chunk +3 lines, -22 lines 0 comments Download
M components/mus/ws/test_utils.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M components/mus/ws/window_manager_state.h View 1 chunk +5 lines, -2 lines 0 comments Download
M components/mus/ws/window_manager_state.cc View 1 chunk +14 lines, -7 lines 0 comments Download
M components/mus/ws/window_tree.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ben Goodger (Google)
Created Revert of mus: Enable system modal windows
4 years, 7 months ago (2016-05-03 17:22:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949603002/1
4 years, 7 months ago (2016-05-03 17:23:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949603002/1
4 years, 7 months ago (2016-05-03 17:32:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949603002/1
4 years, 7 months ago (2016-05-03 18:02:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 18:17:59 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 18:19:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0bc2797737fcc29f952ada285eaab16a7f8c21f
Cr-Commit-Position: refs/heads/master@{#391301}

Powered by Google App Engine
This is Rietveld 408576698