Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1949483002: Added ui::test::MultiLayerAnimatorTestController and Delegate. (Closed)

Created:
4 years, 7 months ago by bruthig
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews, Ian Vollick, tfarina, dcheng, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org, bruthig+ink_drop_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Added ui::test::MultiLayerAnimatorTestController and Delegate. Extracted re-useable code from the views::test::InkDropAnimationTestApi so that it can be reused by the views::test::InkDropHoverTestApi. BUG=604415 Review URL: https://codereview.chromium.org/1900283002 Cr-Commit-Position: refs/heads/master@{#388387} (cherry picked from commit c582d1c3358e0302f997f926a0dc35c97b76f827) Committed: https://chromium.googlesource.com/chromium/src/+/2c5a705a454de5ac1298493ca3327ca740c6feac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -61 lines) Patch
M ui/compositor/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
A ui/compositor/test/multi_layer_animator_test_controller.h View 1 chunk +54 lines, -0 lines 0 comments Download
A ui/compositor/test/multi_layer_animator_test_controller.cc View 1 chunk +66 lines, -0 lines 0 comments Download
A ui/compositor/test/multi_layer_animator_test_controller_delegate.h View 1 chunk +34 lines, -0 lines 0 comments Download
M ui/views/animation/test/flood_fill_ink_drop_animation_test_api.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/test/flood_fill_ink_drop_animation_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/test/ink_drop_animation_test_api.h View 3 chunks +8 lines, -21 lines 0 comments Download
M ui/views/animation/test/ink_drop_animation_test_api.cc View 1 chunk +2 lines, -36 lines 0 comments Download
M ui/views/animation/test/square_ink_drop_animation_test_api.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/test/square_ink_drop_animation_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
bruthig
4 years, 7 months ago (2016-05-03 14:40:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c5a705a454de5ac1298493ca3327ca740c6feac.

Powered by Google App Engine
This is Rietveld 408576698