Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1900283002: Added ui::test::MultiLayerAnimatorTestController and Delegate. (Closed)

Created:
4 years, 8 months ago by bruthig
Modified:
4 years, 8 months ago
Reviewers:
danakj, ajuma
CC:
chromium-reviews, Ian Vollick, tfarina, dcheng, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org, bruthig+ink_drop_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added ui::test::MultiLayerAnimatorTestController and Delegate. Extracted re-useable code from the views::test::InkDropAnimationTestApi so that it can be reused by the views::test::InkDropHoverTestApi. BUG=604415 Committed: https://crrev.com/c582d1c3358e0302f997f926a0dc35c97b76f827 Cr-Commit-Position: refs/heads/master@{#388387}

Patch Set 1 #

Patch Set 2 : Updated gn build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -61 lines) Patch
M ui/compositor/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
A ui/compositor/test/multi_layer_animator_test_controller.h View 1 chunk +54 lines, -0 lines 0 comments Download
A ui/compositor/test/multi_layer_animator_test_controller.cc View 1 chunk +66 lines, -0 lines 0 comments Download
A ui/compositor/test/multi_layer_animator_test_controller_delegate.h View 1 chunk +34 lines, -0 lines 0 comments Download
M ui/views/animation/test/flood_fill_ink_drop_animation_test_api.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/test/flood_fill_ink_drop_animation_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/test/ink_drop_animation_test_api.h View 3 chunks +8 lines, -21 lines 0 comments Download
M ui/views/animation/test/ink_drop_animation_test_api.cc View 1 chunk +2 lines, -36 lines 0 comments Download
M ui/views/animation/test/square_ink_drop_animation_test_api.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/animation/test/square_ink_drop_animation_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
bruthig
ajuma@, can you provide an OWNER's review for ui/compositor/* stuff and just a second set ...
4 years, 8 months ago (2016-04-19 21:02:06 UTC) #2
ajuma
On 2016/04/19 21:02:06, bruthig wrote: > ajuma@, can you provide an OWNER's review for ui/compositor/* ...
4 years, 8 months ago (2016-04-19 21:51:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900283002/20001
4 years, 8 months ago (2016-04-19 22:34:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/170556)
4 years, 8 months ago (2016-04-19 22:40:43 UTC) #7
bruthig
danakj@, can you review: - ui/compositor/BUILD.gn - ui/compositor/compositor.gyp
4 years, 8 months ago (2016-04-19 22:43:58 UTC) #9
danakj
rs lgtm
4 years, 8 months ago (2016-04-19 22:59:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900283002/20001
4 years, 8 months ago (2016-04-20 00:50:00 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 00:58:39 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:19:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c582d1c3358e0302f997f926a0dc35c97b76f827
Cr-Commit-Position: refs/heads/master@{#388387}

Powered by Google App Engine
This is Rietveld 408576698