Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1949463002: Revert of Add Gr*Proxy classes (Closed)

Created:
4 years, 7 months ago by robertphillips
Modified:
4 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add Gr*Proxy classes (patchset #9 id:160001 of https://codereview.chromium.org/1937553002/ ) Reason for revert: Seems to be breaking N7 & ANGLE bots Original issue's description: > Add Gr*Proxy classes > > This isn't wired in anywhere yet. > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1937553002 > > Committed: https://skia.googlesource.com/skia/+/de5bf0cfeca908b81a28cc50065f7bc2da3d2fd1 TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/89d09a1f70280cd0317d8a8d4e8973e5fa43182c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -584 lines) Patch
M gyp/gpu.gypi View 3 chunks +1 line, -7 lines 0 comments Download
M include/core/SkTypes.h View 1 chunk +0 lines, -9 lines 0 comments Download
M include/gpu/GrContext.h View 1 chunk +6 lines, -1 line 0 comments Download
M include/gpu/GrRenderTarget.h View 2 chunks +0 lines, -3 lines 0 comments Download
D include/private/GrRenderTargetProxy.h View 1 chunk +0 lines, -123 lines 0 comments Download
D include/private/GrSurfaceProxy.h View 1 chunk +0 lines, -72 lines 0 comments Download
D include/private/GrTextureProxy.h View 1 chunk +0 lines, -49 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/GrRenderTargetPriv.h View 1 chunk +0 lines, -2 lines 0 comments Download
D src/gpu/GrRenderTargetProxy.cpp View 1 chunk +0 lines, -77 lines 0 comments Download
D src/gpu/GrSurfaceProxy.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
D src/gpu/GrTextureProxy.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ClearTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/PrimitiveProcessorTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
D tests/ProxyTest.cpp View 1 chunk +0 lines, -154 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Add Gr*Proxy classes
4 years, 7 months ago (2016-05-03 13:44:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949463002/1
4 years, 7 months ago (2016-05-03 13:44:41 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 13:44:52 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/89d09a1f70280cd0317d8a8d4e8973e5fa43182c

Powered by Google App Engine
This is Rietveld 408576698