Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1949343002: [Obsolete] Typed CSSOM: Prefix LengthValue, CalcLength and SimpleLength with "CSS" (Closed)

Created:
4 years, 7 months ago by rjwright
Modified:
4 years, 6 months ago
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Typed CSSOM: Prefix LengthValue, CalcLength and SimpleLength with "CSS" Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159 I have decided to replace this patch with 3 smaller ones. #1: https://codereview.chromium.org/1997503003/ #2: #3: BUG=610161

Patch Set 1 #

Patch Set 2 : Fix gypi ordering #

Patch Set 3 : rename layout test files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+624 lines, -1031 lines) Patch
M third_party/WebKit/LayoutTests/typedcssom/calcLength.html View 1 2 1 chunk +0 lines, -76 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/cssCalcLength.html View 1 2 1 chunk +76 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/cssLengthValue.html View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/cssSimpleLength.html View 1 2 1 chunk +136 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_append.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_delete.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getAll.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getProperties.html View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_setGet.html View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/lengthValue.html View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/perspectiveTransformComponent.html View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/positionValue.html View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/simpleLength.html View 1 2 1 chunk +0 lines, -136 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/styleValue-parse-basic.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/translationTransformComponent.html View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 6 chunks +33 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 chunks +10 lines, -10 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSCalcLength.idl View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSLengthValue.h View 3 chunks +17 lines, -17 lines 0 comments Download
A third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp View 1 chunk +91 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/cssom/CSSLengthValue.idl View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.h View 1 chunk +69 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.idl View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSStyleCalcLength.h View 2 chunks +23 lines, -23 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSStyleCalcLength.cpp View 6 chunks +30 lines, -30 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/CalcLength.idl View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/css/cssom/LengthValue.h View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/LengthValue.cpp View 1 chunk +0 lines, -91 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/LengthValue.idl View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/Perspective.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.h View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/PositionValue.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/PositionValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/PositionValue.idl View 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/SimpleLength.h View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/SimpleLength.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/SimpleLength.idl View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/StyleCalcLength.h View 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/StyleCalcLength.cpp View 1 chunk +0 lines, -151 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/Translation.idl View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.h View 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/TranslationTransformComponent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rjwright
4 years, 7 months ago (2016-05-05 04:19:52 UTC) #2
meade_UTC10
lgtm This ended up quite big, it'd be better to do it class by class ...
4 years, 7 months ago (2016-05-05 08:08:59 UTC) #4
Timothy Loh
CSSStyleCalcLength should probably just be called CSSCalcLength? IIRC we called it StyleCalcLength since CalcLength was ...
4 years, 7 months ago (2016-05-11 07:39:11 UTC) #8
rjwright
On 2016/05/11 07:39:11, Timothy Loh wrote: > CSSStyleCalcLength should probably just be called CSSCalcLength? IIRC ...
4 years, 7 months ago (2016-05-12 01:44:33 UTC) #9
Timothy Loh
4 years, 7 months ago (2016-05-26 07:22:26 UTC) #11
No need to leave this open if it's obsolete :)

Powered by Google App Engine
This is Rietveld 408576698