third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl - Issue 1949343002: [Obsolete] Typed CSSOM: Prefix LengthValue, CalcLength and SimpleLength with "CSS"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl

Issue 1949343002: [Obsolete] Typed CSSOM: Prefix LengthValue, CalcLength and SimpleLength with "CSS" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rename layout test files Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl

index 232a5287083ea5c0bad14d5d93c122aea0b9127e..6587e2ded145c760209567fdc56a49ffbff23f2e 100644

--- a/third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl

@@ -7,7 +7,7 @@

#include "core/css/CSSPropertyMetadata.h"

#include "core/css/cssom/CSSOMKeywords.h"

#include "core/css/cssom/KeywordValue.h"

-#include "core/css/cssom/LengthValue.h"

+#include "core/css/cssom/CSSLengthValue.h"

namespace blink {

@@ -15,7 +15,7 @@ bool CSSOMTypes::propertyCanTake(CSSPropertyID id, const StyleValue& styleValue)

{

// Shortcut special case.

if (styleValue.type() == StyleValue::SimpleLengthType || styleValue.type() == StyleValue::CalcLengthType) {

- if (toLengthValue(styleValue).containsPercent() && !CSSPropertyMetadata::propertySupportsPercentage(id)) {

+ if (toCSSLengthValue(styleValue).containsPercent() && !CSSPropertyMetadata::propertySupportsPercentage(id)) {

return false;

}

} else if (styleValue.type() == StyleValue::KeywordType) {