Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3188)

Unified Diff: build_gyp/standalone.gypi

Issue 1949303002: Enable 'treating warnings as errors' for 64 bit Win builds (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | xfa/fxfa/parser/xfa_object_imp.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build_gyp/standalone.gypi
diff --git a/build_gyp/standalone.gypi b/build_gyp/standalone.gypi
index 67ed204409e7c0c08d77c66f38157eb6c6de41d8..be18b5006c905361938211452b179dc33c6bd17c 100644
--- a/build_gyp/standalone.gypi
+++ b/build_gyp/standalone.gypi
@@ -300,6 +300,7 @@
'EnableFunctionLevelLinking': 'true',
'RuntimeTypeInfo': 'false',
'WarningLevel': '3',
+ 'WarnAsError': 'true',
'DebugInformationFormat': '3',
'Detect64BitPortabilityProblems': 'false',
'conditions': [
@@ -311,13 +312,6 @@
}, {
'ExceptionHandling': '0',
}],
- ['target_arch=="x64"', {
- # 64-bit warnings need to be resolved.
- # https://code.google.com/p/pdfium/issues/detail?id=101
- 'WarnAsError': 'false',
- }, {
- 'WarnAsError': 'true',
- }],
['clang==1', {
'AdditionalOptions': [
# Don't warn about unused function parameters.
« no previous file with comments | « no previous file | xfa/fxfa/parser/xfa_object_imp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698