Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: xfa/fxfa/parser/xfa_object_imp.cpp

Issue 1949303002: Enable 'treating warnings as errors' for 64 bit Win builds (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build_gyp/standalone.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxfa/parser/xfa_object_imp.cpp
diff --git a/xfa/fxfa/parser/xfa_object_imp.cpp b/xfa/fxfa/parser/xfa_object_imp.cpp
index 6b438387be810c3f57f07e05ace54fa9ad022ec7..32da7f7a17ee6e80170faaf90635c44fbf00f004 100644
--- a/xfa/fxfa/parser/xfa_object_imp.cpp
+++ b/xfa/fxfa/parser/xfa_object_imp.cpp
@@ -4574,9 +4574,7 @@ CXFA_Node* CXFA_Node::GetChild(int32_t index,
int32_t CXFA_Node::InsertChild(int32_t index, CXFA_Node* pNode) {
ASSERT(!pNode->m_pNext);
pNode->m_pParent = this;
- FX_BOOL bWasPurgeNode = m_pDocument->RemovePurgeNode(pNode);
- if (!bWasPurgeNode)
- ASSERT(false);
+ ASSERT(m_pDocument->RemovePurgeNode(pNode));
if (m_pChild == NULL || index == 0) {
if (index > 0) {
@@ -4617,15 +4615,14 @@ int32_t CXFA_Node::InsertChild(int32_t index, CXFA_Node* pNode) {
}
return index;
}
+
FX_BOOL CXFA_Node::InsertChild(CXFA_Node* pNode, CXFA_Node* pBeforeNode) {
if (!pNode || pNode->m_pParent ||
(pBeforeNode && pBeforeNode->m_pParent != this)) {
ASSERT(false);
return FALSE;
}
- FX_BOOL bWasPurgeNode = m_pDocument->RemovePurgeNode(pNode);
- if (!bWasPurgeNode)
- ASSERT(false);
+ ASSERT(m_pDocument->RemovePurgeNode(pNode));
int32_t nIndex = -1;
pNode->m_pParent = this;
« no previous file with comments | « build_gyp/standalone.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698