Enable 'treating warnings as errors' for 64 bit Win builds

Enable 'treating warnings as errors' for 64 bit Win builds

The reason to disable 'treating warnings as errors' earilier is due to
c4267 warnings, which we already disabled uniformly in pdfium.gyp.
Re-enable this now so that we can have the same level of compilation
warnings/errors on 32 bit and 64 bit builds.

Also fix two c4390 warnings on Windows release builds. Their warning
messages are "empty controlled statement found; is this the intent?"

Committed: https://pdfium.googlesource.com/pdfium/+/6e1ae8614e7c81d8e6a6249ee73cfbf8abb0d099

[Wei Li, 2016-05-05 00:31:15]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org

[Wei Li, 2016-05-05 00:31:16]

for review, thanks

[dsinclair, 2016-05-05 01:10:43]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-05-05 01:10:44]

lgtm

[commit-bot: I haz the power, 2016-05-05 01:10:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949303002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949303002/1

[commit-bot: I haz the power, 2016-05-05 01:25:29]

Description was changed from

==========
Enable 'treating warnings as errors' for 64 bit Win builds

The reason to disable 'treating warnings as errors' earilier is due to
c4267 warnings, which we already disabled uniformly in pdfium.gyp.
Re-enable this now so that we can have the same level of compilation
warnings/errors on 32 bit and 64 bit builds.

Also fix two c4390 warnings on Windows release builds. Their warning
messages are "empty controlled statement found; is this the intent?"
==========

to

==========
Enable 'treating warnings as errors' for 64 bit Win builds

The reason to disable 'treating warnings as errors' earilier is due to
c4267 warnings, which we already disabled uniformly in pdfium.gyp.
Re-enable this now so that we can have the same level of compilation
warnings/errors on 32 bit and 64 bit builds.

Also fix two c4390 warnings on Windows release builds. Their warning
messages are "empty controlled statement found; is this the intent?"

Committed:
https://pdfium.googlesource.com/pdfium/+/6e1ae8614e7c81d8e6a6249ee73cfbf8abb0...
==========

[commit-bot: I haz the power, 2016-05-05 01:25:30]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/6e1ae8614e7c81d8e6a6249ee73cfbf8abb0...