Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 194923008: Revert "De-virtualize SkCanvas save/restore." (Closed)

Created:
6 years, 9 months ago by f(malita)
Modified:
6 years, 9 months ago
Reviewers:
hal.canary
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Revert "De-virtualize SkCanvas save/restore." (To allow a roll fix into the tree). This reverts commit edf702204be42c945254191f9f9cd6585b3d189b. R=halcanary@google.com Committed: https://code.google.com/p/skia/source/detail?r=13748

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -177 lines) Patch
M experimental/PdfViewer/SkNulCanvas.h View 2 chunks +7 lines, -6 lines 0 comments Download
M include/core/SkCanvas.h View 5 chunks +5 lines, -13 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 2 chunks +4 lines, -4 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 2 chunks +5 lines, -4 lines 0 comments Download
M include/utils/SkLuaCanvas.h View 2 chunks +5 lines, -4 lines 0 comments Download
M include/utils/SkNWayCanvas.h View 2 chunks +4 lines, -4 lines 0 comments Download
M include/utils/SkProxyCanvas.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/core/SkBBoxHierarchyRecord.h View 2 chunks +5 lines, -4 lines 0 comments Download
M src/core/SkBBoxHierarchyRecord.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M src/core/SkCanvas.cpp View 6 chunks +3 lines, -25 lines 0 comments Download
M src/core/SkPictureRecord.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 6 chunks +13 lines, -11 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 4 chunks +14 lines, -17 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +12 lines, -9 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 2 chunks +7 lines, -10 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 chunk +7 lines, -11 lines 0 comments Download
M src/utils/SkNoSaveLayerCanvas.h View 1 chunk +13 lines, -5 lines 0 comments Download
M src/utils/SkProxyCanvas.cpp View 1 chunk +6 lines, -11 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 2 chunks +6 lines, -4 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 2 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
f(malita)
6 years, 9 months ago (2014-03-11 21:38:27 UTC) #1
hal.canary
lgtm
6 years, 9 months ago (2014-03-11 21:41:39 UTC) #2
f(malita)
Committed patchset #1 manually as r13748.
6 years, 9 months ago (2014-03-11 21:47:07 UTC) #3
fmalita_google_do_not_use
6 years, 9 months ago (2014-03-11 23:46:56 UTC) #4
Message was sent while issue was closed. 
A revert of this CL has been created in
https://codereview.chromium.org/196323003/ by fmalita@google.com.

The reason for reverting is: Re-landing after roll fix..

Powered by Google App Engine
This is Rietveld 408576698