Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: src/utils/SkNoSaveLayerCanvas.h

Issue 194923008: Revert "De-virtualize SkCanvas save/restore." (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/utils/SkNWayCanvas.cpp ('k') | src/utils/SkProxyCanvas.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef SkNoSaveLayerCanvas_DEFINED 8 #ifndef SkNoSaveLayerCanvas_DEFINED
9 #define SkNoSaveLayerCanvas_DEFINED 9 #define SkNoSaveLayerCanvas_DEFINED
10 10
11 #include "SkCanvas.h" 11 #include "SkCanvas.h"
12 #include "SkRRect.h" 12 #include "SkRRect.h"
13 13
14 // The NoSaveLayerCanvas is used to play back SkPictures when the saveLayer 14 // The NoSaveLayerCanvas is used to play back SkPictures when the saveLayer
15 // functionality isn't required (e.g., during analysis of the draw calls). 15 // functionality isn't required (e.g., during analysis of the draw calls).
16 // It also simplifies the clipping calls to only use rectangles. 16 // It also simplifies the clipping calls to only use rectangles.
17 class SkNoSaveLayerCanvas : public SkCanvas { 17 class SkNoSaveLayerCanvas : public SkCanvas {
18 public: 18 public:
19 SkNoSaveLayerCanvas(SkBaseDevice* device) : INHERITED(device) {} 19 SkNoSaveLayerCanvas(SkBaseDevice* device) : INHERITED(device) {}
20 20
21 protected: 21 // turn saveLayer() into save() for speed, should not affect correctness.
22 virtual bool onSaveLayer(const SkRect* bounds, const SkPaint* paint, SaveFla gs flags) 22 virtual int saveLayer(const SkRect* bounds,
23 SK_OVERRIDE { 23 const SkPaint* paint,
24 this->INHERITED::onSaveLayer(bounds, paint, flags); 24 SaveFlags flags) SK_OVERRIDE {
25 return false; 25
26 // Like SkPictureRecord, we don't want to create layers, but we do need
27 // to respect the save and (possibly) its rect-clip.
28 int count = this->INHERITED::save(flags);
29 if (NULL != bounds) {
30 this->INHERITED::clipRectBounds(bounds, flags, NULL);
31 }
32 return count;
26 } 33 }
27 34
35 protected:
28 // disable aa for speed 36 // disable aa for speed
29 virtual void onClipRect(const SkRect& rect, SkRegion::Op op, ClipEdgeStyle) SK_OVERRIDE { 37 virtual void onClipRect(const SkRect& rect, SkRegion::Op op, ClipEdgeStyle) SK_OVERRIDE {
30 this->INHERITED::onClipRect(rect, op, kHard_ClipEdgeStyle); 38 this->INHERITED::onClipRect(rect, op, kHard_ClipEdgeStyle);
31 } 39 }
32 40
33 // for speed, just respect the bounds, and disable AA. May give us a few 41 // for speed, just respect the bounds, and disable AA. May give us a few
34 // false positives and negatives. 42 // false positives and negatives.
35 virtual void onClipPath(const SkPath& path, SkRegion::Op op, ClipEdgeStyle) SK_OVERRIDE { 43 virtual void onClipPath(const SkPath& path, SkRegion::Op op, ClipEdgeStyle) SK_OVERRIDE {
36 this->updateClipConservativelyUsingBounds(path.getBounds(), op, 44 this->updateClipConservativelyUsingBounds(path.getBounds(), op,
37 path.isInverseFillType()); 45 path.isInverseFillType());
38 } 46 }
39 virtual void onClipRRect(const SkRRect& rrect, SkRegion::Op op, ClipEdgeStyl e) SK_OVERRIDE { 47 virtual void onClipRRect(const SkRRect& rrect, SkRegion::Op op, ClipEdgeStyl e) SK_OVERRIDE {
40 this->updateClipConservativelyUsingBounds(rrect.getBounds(), op, false); 48 this->updateClipConservativelyUsingBounds(rrect.getBounds(), op, false);
41 } 49 }
42 50
43 private: 51 private:
44 typedef SkCanvas INHERITED; 52 typedef SkCanvas INHERITED;
45 }; 53 };
46 54
47 #endif // SkNoSaveLayerCanvas_DEFINED 55 #endif // SkNoSaveLayerCanvas_DEFINED
OLDNEW
« no previous file with comments | « src/utils/SkNWayCanvas.cpp ('k') | src/utils/SkProxyCanvas.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698