Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 19490004: Make it possible to compile ICU both with the host and target toolset. (Closed)

Created:
7 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, jungshik at Google
Visibility:
Public.

Description

Make it possible to compile ICU both with the host and target toolset. If the system ICU library is supposed to be used, still compile ICU for the host toolset if we're using separate host and target toolsets, as the system ICU in general is only available for the target. BUG=none R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212587

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -19 lines) Patch
M icu.gyp View 9 chunks +60 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
please review Note that chromium does not define "want_separate_host_toolset", however, v8 defines it as 1. ...
7 years, 5 months ago (2013-07-19 12:00:48 UTC) #1
jochen (gone - plz use gerrit)
+jshin@ fyi
7 years, 5 months ago (2013-07-19 12:08:51 UTC) #2
Mark Mentovai
LGTM
7 years, 5 months ago (2013-07-19 13:56:22 UTC) #3
jochen (gone - plz use gerrit)
7 years, 5 months ago (2013-07-19 15:30:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r212587 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698