Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3500)

Unified Diff: icu.gyp

Issue 19490004: Make it possible to compile ICU both with the host and target toolset. (Closed) Base URL: svn://chrome-svn/chrome/trunk/deps/third_party/icu46/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: icu.gyp
===================================================================
--- icu.gyp (revision 212565)
+++ icu.gyp (working copy)
@@ -6,6 +6,7 @@
'variables': {
'use_system_icu%': 0,
'icu_use_data_file_flag%': 0,
+ 'want_separate_host_toolset%': 0,
},
'target_defaults': {
'direct_dependent_settings': {
@@ -15,26 +16,24 @@
'U_USING_ICU_NAMESPACE=0',
],
},
+ 'defines': [
+ 'U_USING_ICU_NAMESPACE=0',
+ ],
+ 'conditions': [
+ ['component=="static_library"', {
+ 'defines': [
+ 'U_STATIC_IMPLEMENTATION',
+ ],
+ }],
+ ],
+ 'include_dirs': [
+ 'source/common',
+ 'source/i18n',
+ ],
+ 'msvs_disabled_warnings': [4005, 4068, 4355, 4996, 4267],
},
'conditions': [
- ['use_system_icu==0', {
- 'target_defaults': {
- 'defines': [
- 'U_USING_ICU_NAMESPACE=0',
- ],
- 'conditions': [
- ['component=="static_library"', {
- 'defines': [
- 'U_STATIC_IMPLEMENTATION',
- ],
- }],
- ],
- 'include_dirs': [
- 'source/common',
- 'source/i18n',
- ],
- 'msvs_disabled_warnings': [4005, 4068, 4355, 4996, 4267],
- },
+ ['use_system_icu==0 or want_separate_host_toolset==1', {
'targets': [
{
'target_name': 'icudata',
@@ -52,6 +51,11 @@
'mac/icudt46l_dat.S',
],
'conditions': [
+ [ 'use_system_icu==1', {
+ 'toolsets': ['host'],
+ }, {
+ 'toolsets': ['host', 'target'],
+ }],
[ 'OS == "win"', {
'type': 'none',
'copies': [
@@ -262,6 +266,11 @@
],
},
'conditions': [
+ [ 'use_system_icu==1', {
+ 'toolsets': ['host'],
+ }, {
+ 'toolsets': ['host', 'target'],
+ }],
[ 'os_posix == 1 and OS != "mac" and OS != "ios"', {
# Since ICU wants to internally use its own deprecated APIs, don't
# complain about it.
@@ -508,6 +517,11 @@
],
},
'conditions': [
+ [ 'use_system_icu==1', {
+ 'toolsets': ['host'],
+ }, {
+ 'toolsets': ['host', 'target'],
+ }],
[ 'OS == "win"', {
'sources': [
'source/stubdata/stubdata.c',
@@ -575,12 +589,18 @@
],
},
],
- }, { # use_system_icu != 0
+ }],
+ ['use_system_icu==1', {
'targets': [
{
'target_name': 'system_icu',
'type': 'none',
'conditions': [
+ ['want_separate_host_toolset==1', {
+ 'toolsets': ['target'],
+ }, {
+ 'toolsets': ['host', 'target'],
+ }],
['OS=="android"', {
'direct_dependent_settings': {
'include_dirs': [
@@ -611,6 +631,13 @@
'type': 'none',
'dependencies': ['system_icu'],
'export_dependent_settings': ['system_icu'],
+ 'conditions': [
+ ['want_separate_host_toolset==1', {
+ 'toolsets': ['target'],
+ }, {
+ 'toolsets': ['host', 'target'],
+ }],
+ ],
},
{
'target_name': 'icui18n',
@@ -697,6 +724,13 @@
'includes': [
'../../build/shim_headers.gypi',
],
+ 'conditions': [
+ ['want_separate_host_toolset==1', {
+ 'toolsets': ['target'],
+ }, {
+ 'toolsets': ['host', 'target'],
+ }],
+ ],
},
{
'target_name': 'icuuc',
@@ -801,6 +835,13 @@
'includes': [
'../../build/shim_headers.gypi',
],
+ 'conditions': [
+ ['want_separate_host_toolset==1', {
+ 'toolsets': ['target'],
+ }, {
+ 'toolsets': ['host', 'target'],
+ }],
+ ],
},
],
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698