Add a main menu to the shim that matches the one in Chrome.

apps/app_shim/chrome_main_app_mode_mac.mm

Index: apps/app_shim/chrome_main_app_mode_mac.mm
diff --git a/apps/app_shim/chrome_main_app_mode_mac.mm b/apps/app_shim/chrome_main_app_mode_mac.mm
index 2302b047b7e464779dc016a6d668ed2fa6e9de36..8d80d3f439d86344c42434da4d8d9e5860f7e9b9 100644
--- a/apps/app_shim/chrome_main_app_mode_mac.mm
+++ b/apps/app_shim/chrome_main_app_mode_mac.mm
@@ -64,6 +64,9 @@ class AppShimController : public IPC::Listener {
   // Connects to Chrome and sends a LaunchApp message.
   void Init();
 
+  // Builds main menu bar items.
+  void SetUpMenu();
+
   void SendSetAppHidden(bool hidden);
 
   void SendQuitApp();
@@ -97,6 +100,10 @@ AppShimController::AppShimController() : channel_(NULL),
 
 void AppShimController::Init() {
   DCHECK(g_io_thread);
+
+  SetUpMenu();
+
+  // Open an IPC channel to Chrome and send the initial app launch message.
   NSString* chrome_bundle_path =
       base::SysUTF8ToNSString(g_info->chrome_outer_bundle_path.value());
   NSBundle* chrome_bundle = [NSBundle bundleWithPath:chrome_bundle_path];
@@ -123,6 +130,34 @@ void AppShimController::Init() {
   [NSApp setDelegate:nsapp_delegate_];
 }
 
+void AppShimController::SetUpMenu() {
+  // The title of the first item is replaced by OSX with the name of the app and
+  // bold styling. Since the title can't be replaced, it is hidden in Chrome and
+  // the app title has non-bold styling. We can match that here by adding a
+  // first element and hiding it.
+  NSString* title = base::SysUTF16ToNSString(g_info->app_mode_name);
+  base::scoped_nsobject<NSMenu> mainMenu([[NSMenu alloc] initWithTitle:title]);

[tapted, 2013/07/17 07:48:24]

nit: mainMenu -> main_menu, since we're in a C++ class

[jackhou1, 2013/07/22 00:51:46]

Done.

+  for (int i = 0; i < 2; ++i) {

[tapted, 2013/07/17 07:48:24]

Not sure you need the loop.. can you explain the approach some more. E.g. are
you replacing the whole [NSApp mainMenu] to avoid a conflict with the
keyEquivalent on the existing Quit item?

E.g. does something like this work, or are items without submenus skipped in the
mainMenu somehow:

// Put a dummy item at index 0, and hide it.
[[main_menu addItemWithTitle:title
                      action:nil
               keyEquivalent:@""] setHidden:YES];

// Construct an unbolded app menu, to match how it appears with Chrome active.
base::scoped_nsobject<NSMenu> submenu([[NSMenu alloc] initWithTitle:title]);
[submenu addItemWithTitle:[quit stringByAppendingString:title]
                   action:@selector(terminate:)
            keyEquivalent:@"q"];
NSMenuItem* app_name_item = [main_menu addItemWithTitle:title
                                                 action:nil
                                          keyEquivalent:@""];
[app_name_item setSubmenu:submenu];
[NSApp setMainMenu:mainMenu];


And.. is it worth adding Quit at all? i.e. Should the user ever see it? And,
when they do try to use it, is it expected to work, or will it always freeze
(since otherwise it would have focussed Chrome).

[jackhou1, 2013/07/22 00:51:46]

Done.

Yeah, when all of the app's windows are closed, you can still Cmd+Tab to the app
shim. Chrome does not focus because there are no windows for that app.

+    base::scoped_nsobject<NSMenuItem> item(
+        [[NSMenuItem alloc] initWithTitle:title
+                                   action:nil
+                            keyEquivalent:@""]);
+    base::scoped_nsobject<NSMenu> menu([[NSMenu alloc] initWithTitle:title]);
+    [item setSubmenu:menu];
+    [mainMenu addItem:item];
+  }
+  [[mainMenu itemAtIndex:0] setHidden:YES];
+
+  NSMenu* submenu = [[mainMenu itemAtIndex:1] submenu];
+  base::scoped_nsobject<NSMenuItem> item(
+      [[NSMenuItem alloc] initWithTitle:[@"Quit " stringByAppendingString:title]

[tapted, 2013/07/17 07:48:24]

I think you need localization on the string "Quit"

[jackhou1, 2013/07/22 00:51:46]

This turns out to be harder than I thought because the shim doesn't have access
to Chrome's localized resources. The solution will probably be to add IPC
messages to get UI strings from Chrome. I'll do that in another CL.

[tapted, 2013/07/22 02:35:09]

Can you just call

   ResourceBundle::InitSharedInstanceLocaleOnly(
      const std::string& pref_locale, Delegate* delegate);

A NULL delegate might work, otherwise you can probably implement implement a
ResourceBundle::Delegate that implements GetPathForLocalePack, or call one of
the SetOverride*BundlePath functions.

It looks like app_mode_app already depends on the ui library via
infoplist_strings_tool, so you might not even have to add and dependencies (or
you might need a direct dependency to pick up an include path).

[jackhou1, 2013/07/22 11:27:04]

Ah yup, this is necessary. I also needed to add an include to the gypi, and set
the framework bundle path.

+                                 action:@selector(terminate:)
+                          keyEquivalent:@"q"]);
+  [submenu addItem:item];
+
+  [NSApp setMainMenu:mainMenu];
+}
+
 void AppShimController::SendQuitApp() {
   channel_->Send(new AppShimHostMsg_QuitApp);
 }