Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1948813002: [Polymer10] Port dashboard buttons to Polymer 1.0 (Closed)

Created:
4 years, 7 months ago by eakuefner
Modified:
4 years, 7 months ago
Reviewers:
sullivan, dtu
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@polymer10-migration
Target Ref:
refs/heads/polymer10-migration
Project:
catapult
Visibility:
Public.

Description

[Polymer10] Port dashboard buttons to Polymer 1.0 BUG=catapult:#2285 NOTRY=true NOPRESUBMIT=true Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/802ccedf03582f5e30e563fe8eb0ac0ecf9c6d3a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Annie's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -14 lines) Patch
M dashboard/dashboard/elements/bisect-button.html View 3 chunks +15 lines, -4 lines 0 comments Download
M dashboard/dashboard/elements/chart-legend.html View 1 1 chunk +1 line, -1 line 0 comments Download
M dashboard/dashboard/elements/primary-button.html View 2 chunks +12 lines, -3 lines 0 comments Download
M dashboard/dashboard/elements/trace-button.html View 1 4 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
eakuefner
Please, take a look.
4 years, 7 months ago (2016-05-03 21:47:38 UTC) #2
sullivan
lgtm lgtm after fixing typo https://codereview.chromium.org/1948813002/diff/1/dashboard/dashboard/elements/trace-button.html File dashboard/dashboard/elements/trace-button.html (right): https://codereview.chromium.org/1948813002/diff/1/dashboard/dashboard/elements/trace-button.html#newcode26 dashboard/dashboard/elements/trace-button.html:26: background-color: #42 I think ...
4 years, 7 months ago (2016-05-03 21:49:00 UTC) #3
eakuefner
https://codereview.chromium.org/1948813002/diff/1/dashboard/dashboard/elements/trace-button.html File dashboard/dashboard/elements/trace-button.html (right): https://codereview.chromium.org/1948813002/diff/1/dashboard/dashboard/elements/trace-button.html#newcode26 dashboard/dashboard/elements/trace-button.html:26: background-color: #42 On 2016/05/03 at 21:49:00, sullivan wrote: > ...
4 years, 7 months ago (2016-05-03 21:57:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948813002/20001
4 years, 7 months ago (2016-05-03 21:57:26 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 7 months ago (2016-05-03 21:57:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948813002/20001
4 years, 7 months ago (2016-05-04 00:32:58 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 00:33:08 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698