Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: dashboard/dashboard/elements/trace-button.html

Issue 1948813002: [Polymer10] Port dashboard buttons to Polymer 1.0 (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Address Annie's comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/elements/primary-button.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/elements/trace-button.html
diff --git a/dashboard/dashboard/elements/trace-button.html b/dashboard/dashboard/elements/trace-button.html
index 51f9685ecb2d69c02291f5d83069e16093ce3c59..604abe601420b3fb9559bc5c2b11f7ae077a522d 100644
--- a/dashboard/dashboard/elements/trace-button.html
+++ b/dashboard/dashboard/elements/trace-button.html
@@ -15,7 +15,7 @@ See https://github.com/catapult-project/catapult/issues/1905
<link rel="import" href="/dashboard/elements/trace-form.html">
<link rel="import" href="/dashboard/static/simple_xhr.html">
-<polymer-element name="trace-button" attributes="traceInfo bugId xsrfToken">
+<dom-module id="trace-button">
<template>
<style>
/*
@@ -36,9 +36,9 @@ See https://github.com/catapult-project/catapult/issues/1905
</style>
<paper-button raised
id="button"
- disabled?={{!canTrace}}
- enabled?={{canTrace}}
- on-click="{{onTrace}}">Trace</paper-button>
+ disabled$={{!canTrace}}
+ enabled$={{canTrace}}
+ on-click="onTrace">Trace</paper-button>
<trace-form
id="trace"
xsrfToken="{{xsrfToken}}"
@@ -51,7 +51,18 @@ See https://github.com/catapult-project/catapult/issues/1905
<script>
'use strict';
(function() {
- Polymer('trace-button', {
+ Polymer({
+
+ is: 'trace-button',
+ properties: {
+ bugId: { notify: true },
+ traceInfo: {
+ notify: true,
+ observer: 'traceInfoChanged'
+ },
+ xsrfToken: { notify: true }
+ }
+
/**
* Initializes this element; this is an element lifecycle callback.
*/
@@ -100,4 +111,4 @@ See https://github.com/catapult-project/catapult/issues/1905
});
})();
</script>
-</polymer-element>
+</dom-module>
« no previous file with comments | « dashboard/dashboard/elements/primary-button.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698