Issue 1948773002: Create array of extension views without side effects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1948773002: Create array of extension views without side effects (Closed)

Created:
4 years, 7 months ago by robwu

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Create array of extension views without side effects BUG=608104 Review-Url: https://codereview.chromium.org/1935953002 Cr-Commit-Position: refs/heads/master@{#390961} (cherry picked from commit aa7a889002dd7a1288cc5e962086e517131fb01e) Committed: https://chromium.googlesource.com/chromium/src/+/3d0effb3db93713cafeea3bc81231403b5cba018

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	extensions/renderer/runtime_custom_bindings.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

robwu

4 years, 7 months ago (2016-05-03 21:25:28 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3d0effb3db93713cafeea3bc81231403b5cba018.