Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1935953002: Create array of extension views without side effects (Closed)

Created:
4 years, 7 months ago by robwu
Modified:
4 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create array of extension views without side effects BUG=608104 Committed: https://crrev.com/aa7a889002dd7a1288cc5e962086e517131fb01e Cr-Commit-Position: refs/heads/master@{#390961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M extensions/renderer/runtime_custom_bindings.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
robwu
4 years, 7 months ago (2016-04-30 14:58:38 UTC) #2
Devlin
lgtm
4 years, 7 months ago (2016-05-02 13:54:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1935953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1935953002/1
4 years, 7 months ago (2016-05-02 15:22:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 16:18:47 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 16:21:41 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aa7a889002dd7a1288cc5e962086e517131fb01e
Cr-Commit-Position: refs/heads/master@{#390961}

Powered by Google App Engine
This is Rietveld 408576698