Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3086)

Unified Diff: blimp/engine/app/blimp_metrics_service_client_unittest.cc

Issue 1948733003: Revert of Create and integrate a metrics service client into Blimp engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/app/blimp_metrics_service_client.cc ('k') | blimp/engine/common/blimp_browser_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/app/blimp_metrics_service_client_unittest.cc
diff --git a/blimp/engine/app/blimp_metrics_service_client_unittest.cc b/blimp/engine/app/blimp_metrics_service_client_unittest.cc
deleted file mode 100644
index 956e4ab214e83c35669ac99dc049855a22a06da3..0000000000000000000000000000000000000000
--- a/blimp/engine/app/blimp_metrics_service_client_unittest.cc
+++ /dev/null
@@ -1,94 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "blimp/engine/app/blimp_metrics_service_client.h"
-
-#include <list>
-#include <string>
-
-#include "base/memory/ref_counted.h"
-#include "base/message_loop/message_loop.h"
-#include "base/run_loop.h"
-#include "base/test/test_simple_task_runner.h"
-#include "base/thread_task_runner_handle.h"
-#include "components/metrics/metrics_service.h"
-#include "components/pref_registry/pref_registry_syncable.h"
-#include "components/prefs/in_memory_pref_store.h"
-#include "components/prefs/pref_service.h"
-#include "components/prefs/pref_service_factory.h"
-#include "net/url_request/url_request_context_getter.h"
-#include "net/url_request/url_request_test_util.h"
-#include "testing/gmock/include/gmock/gmock.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace blimp {
-namespace engine {
-// Shows notifications which correspond to PersistentPrefStore's reading errors.
-void HandleReadError(PersistentPrefStore::PrefReadError error) {
-}
-
-class BlimpMetricsServiceClientTest : public testing::Test {
- protected:
- void SetUp() override;
- void TearDown() override;
-
- void SetUpPrefRegistry();
- void SetUpPrefService();
- void SetUpRequestContextGetter();
-
- base::MessageLoop message_loop_;
- scoped_refptr<user_prefs::PrefRegistrySyncable> pref_registry_;
- std::unique_ptr<PrefService> pref_service_;
- scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
-};
-
-void BlimpMetricsServiceClientTest::SetUp() {
- // Set up all deps and then InitializeBlimpMetrics.
- SetUpPrefRegistry();
- SetUpPrefService();
- SetUpRequestContextGetter();
- base::SetRecordActionTaskRunner(message_loop_.task_runner());
- InitializeBlimpMetrics(std::move(pref_service_), request_context_getter_);
- base::RunLoop().RunUntilIdle();
-
- // Checks of InitializeBlimpMetrics.
- // TODO(jessicag): Check request_context_getter_ set.
- // PrefService unique pointer moved to BlimpMetricsServiceClient.
- EXPECT_EQ(nullptr, pref_service_.get());
-
- // TODO(jessicag): Confirm registration of metrics providers.
- // TODO(jessicag): MetricsService initializes recording state.
- // TODO(jessicag): Confirm MetricsService::Start() is called.
-}
-
-void BlimpMetricsServiceClientTest::TearDown() {
- FinalizeBlimpMetrics();
- base::RunLoop().RunUntilIdle();
- // TODO(jessicag): Ensure MetricsService::Stop() is called.
-}
-
-void BlimpMetricsServiceClientTest::SetUpPrefRegistry() {
- pref_registry_ = new user_prefs::PrefRegistrySyncable();
- metrics::MetricsService::RegisterPrefs(pref_registry_.get());
-}
-
-void BlimpMetricsServiceClientTest::SetUpPrefService() {
- PrefServiceFactory pref_service_factory;
- pref_service_factory.set_user_prefs(new InMemoryPrefStore());
- pref_service_factory.set_read_error_callback(base::Bind(&HandleReadError));
- pref_service_ = pref_service_factory.Create(pref_registry_.get());
- ASSERT_NE(nullptr, pref_service_.get());
-}
-
-void BlimpMetricsServiceClientTest::SetUpRequestContextGetter() {
- request_context_getter_ =
- new net::TestURLRequestContextGetter(base::ThreadTaskRunnerHandle::Get());
-}
-
-TEST_F(BlimpMetricsServiceClientTest, InitializeFinalize) {
- // SetUp and TearDown handle initialization and finalization checks.
-}
-
-} // namespace engine
-} // namespace blimp
« no previous file with comments | « blimp/engine/app/blimp_metrics_service_client.cc ('k') | blimp/engine/common/blimp_browser_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698