Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: blimp/engine/BUILD.gn

Issue 1948733003: Revert of Create and integrate a metrics service client into Blimp engine. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | blimp/engine/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/BUILD.gn
diff --git a/blimp/engine/BUILD.gn b/blimp/engine/BUILD.gn
index f88a2ed03f0a0c6153bcc604f4851b2752465681..3c9d0d794ddaeaf23b4708c7af79fb42fbfde93b 100644
--- a/blimp/engine/BUILD.gn
+++ b/blimp/engine/BUILD.gn
@@ -55,10 +55,6 @@
"app/blimp_content_main_delegate.h",
]
- public_deps = [
- ":app_metrics",
- ]
-
deps = [
":app_config",
":app_net",
@@ -75,14 +71,6 @@
"//blimp/common/proto",
"//blimp/engine:blob_channel_mojo_cpp_sources",
"//blimp/net",
- "//components/metrics",
- "//components/metrics:gpu",
- "//components/metrics:net",
- "//components/metrics:profiler",
- "//components/metrics:ui",
- "//components/prefs",
- "//components/web_cache/renderer",
- "//content",
"//content/public/app:both",
"//content/public/browser",
"//content/public/common",
@@ -100,30 +88,6 @@
deps = [
":app_switches",
"//base",
- ]
-}
-
-source_set("app_metrics") {
- sources = [
- "app/blimp_metrics_service_client.cc",
- "app/blimp_metrics_service_client.h",
- ]
-
- public_deps = [
- "//components/metrics",
- "//content/public/browser",
- ]
-
- deps = [
- "//base",
- "//base:i18n",
- "//components/metrics:gpu",
- "//components/metrics:net",
- "//components/metrics:profiler",
- "//components/metrics:ui",
- "//components/prefs",
- "//components/version_info",
- "//net",
]
}
@@ -211,15 +175,11 @@
]
deps = [
- ":app_metrics",
":app_net",
":app_permissions",
":common_user_agent",
"//base",
- "//components/metrics",
- "//components/pref_registry",
- "//components/prefs",
- "//components/version_info",
+ "//content/public/browser",
"//content/public/common",
"//net",
"//ui/base",
@@ -334,7 +294,6 @@
sources = [
"app/blimp_engine_config_unittest.cc",
- "app/blimp_metrics_service_client_unittest.cc",
"app/settings_manager_unittest.cc",
"app/ui/blimp_screen_unittest.cc",
]
@@ -342,16 +301,12 @@
deps = [
":app",
":app_config",
- ":app_metrics",
":app_settings",
":app_switches",
"//base",
"//base/test:run_all_unittests",
"//base/test:test_support",
"//blimp/engine:app_ui",
- "//components/pref_registry:pref_registry",
- "//components/prefs:prefs",
- "//net:test_support",
"//testing/gmock",
"//testing/gtest",
"//ui/display",
« no previous file with comments | « no previous file | blimp/engine/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698